Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-3519

Refactor the logic behind sending of the selector arguments during subscription creation

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15
    • Component/s: Java Client
    • Labels:
      None

      Description

      In current implementation the FieldTable with JMS selector is created in AMQSession#createConsumerImpl.

      The 0-8 MessageConsumer code creates a new FieldTable objects when sending its BasicConsime method.

      The 0-10 AMQSession code does send an arguments map sourced from the consumer when doing the 'sendConsume' method.

      Also, both clients send FieldTable with the selector argument they do it using different FieldTable objects.

      This needs to be improved to allow both clients to reuse the same code.

        Activity

        Hide
        alex.rufous Alex Rudyy added a comment -

        Attached a patch refactoring consumer argument handling

        Show
        alex.rufous Alex Rudyy added a comment - Attached a patch refactoring consumer argument handling
        Hide
        alex.rufous Alex Rudyy added a comment -

        Keith,
        could you please review and commit attached patch?

        Show
        alex.rufous Alex Rudyy added a comment - Keith, could you please review and commit attached patch?
        Hide
        k-wall Keith Wall added a comment -

        No comments, patch applied.

        Show
        k-wall Keith Wall added a comment - No comments, patch applied.

          People

          • Assignee:
            k-wall Keith Wall
            Reporter:
            gemmellr Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development