[QPID-2455] Use msg.getSize() rather than getContentHeaderBody in NotificationCheck to avoid an access to persistence layer

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.5
• Labels: broker qpid
• Assignee: Robbie Gemmell
• Reporter: Sorin Suciu
• Created: 18/Mar/10 12:51
• Updated: 28/Sep/10 09:44
• Resolved: 04/Sep/10 00:20

Description

We have the following sequence in the broker (v.0.5):

		+--NotificationCheck:isMessageSpecific (org.apache.qpid.server.queue)
		+--NotificationCheck$2:notifyIfNecessary (org.apache.qpid.server.queue)
			+--SimpleAMQQueue:getMaximumMessageSize (org.apache.qpid.server.queue)
			+--AMQMessage:getContentHeaderBody (org.apache.qpid.server.queue)
				+--AMQMessage:getStoreContext (org.apache.qpid.server.queue)
				+--WeakReferenceMessageHandle:getContentHeaderBody (org.apache.qpid.server.queue)
					+--WeakReferenceMessageHandle:loadMessageMetaData (org.apache.qpid.server.queue)
						+--BDBMessageStore:getMessageMetaData (org.apache.qpid.server.store.berkeleydb)

getContentHeaderBody could be replaced with msg.getSize() which would save going to BDB.