Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-2455

Use msg.getSize() rather than getContentHeaderBody in NotificationCheck to avoid an access to persistence layer

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.5
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      We have the following sequence in the broker (v.0.5):

          +--NotificationCheck:isMessageSpecific (org.apache.qpid.server.queue)
          +--NotificationCheck$2:notifyIfNecessary (org.apache.qpid.server.queue)
            +--SimpleAMQQueue:getMaximumMessageSize (org.apache.qpid.server.queue)
            +--AMQMessage:getContentHeaderBody (org.apache.qpid.server.queue)
              +--AMQMessage:getStoreContext (org.apache.qpid.server.queue)
              +--WeakReferenceMessageHandle:getContentHeaderBody (org.apache.qpid.server.queue)
                +--WeakReferenceMessageHandle:loadMessageMetaData (org.apache.qpid.server.queue)
                  +--BDBMessageStore:getMessageMetaData (org.apache.qpid.server.store.berkeleydb)

      getContentHeaderBody could be replaced with msg.getSize() which would save going to BDB.

        Attachments

          Activity

            People

            • Assignee:
              gemmellr Robbie Gemmell
              Reporter:
              sorins Sorin Suciu
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: