Qpid
  1. Qpid
  2. QPID-2455

Use msg.getSize() rather than getContentHeaderBody in NotificationCheck to avoid an access to persistence layer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      We have the following sequence in the broker (v.0.5):

          +--NotificationCheck:isMessageSpecific (org.apache.qpid.server.queue)
          +--NotificationCheck$2:notifyIfNecessary (org.apache.qpid.server.queue)
            +--SimpleAMQQueue:getMaximumMessageSize (org.apache.qpid.server.queue)
            +--AMQMessage:getContentHeaderBody (org.apache.qpid.server.queue)
              +--AMQMessage:getStoreContext (org.apache.qpid.server.queue)
              +--WeakReferenceMessageHandle:getContentHeaderBody (org.apache.qpid.server.queue)
                +--WeakReferenceMessageHandle:loadMessageMetaData (org.apache.qpid.server.queue)
                  +--BDBMessageStore:getMessageMetaData (org.apache.qpid.server.store.berkeleydb)

      getContentHeaderBody could be replaced with msg.getSize() which would save going to BDB.

        Activity

        Sorin Suciu created issue -
        Sorin Suciu made changes -
        Field Original Value New Value
        Attachment qpid-2455.patch [ 12440871 ]
        Sorin Suciu made changes -
        Attachment qpid-2455.patch [ 12440871 ]
        Sorin Suciu made changes -
        Attachment qpid-2455.patch [ 12440872 ]
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -

        Patch applied to branch. Trunk has already been fixed previously.

        Show
        Robbie Gemmell added a comment - Patch applied to branch. Trunk has already been fixed previously.
        Sorin Suciu made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sorin Suciu made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development