[PROTON-1892] transfers for multiplexed deliveries on the same session can have the wrong delivery-id

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: proton-j-0.27.1
• Fix Version/s: proton-j-0.27.2, proton-j-0.28.0
• Component/s: proton-j
• Assignee: Robbie Gemmell
• Reporter: Marcel Meulemans
• Created: 10/Jul/18 22:59
• Updated: 31/Jul/18 14:39
• Resolved: 11/Jul/18 20:30

Description

Given a session with two outgoing links the situation can occur that two deliveries on separate links share the same delivery-id. This situation occurs when a multi frame transfer is being sent on link A and a new (single frame) transfer is sent (multiplexed) on link B before the delivery on link A completes. The reason this occurs is because the increment of the delivery id counter (maintained per session) is delayed until the entire (multi frame) delivery is complete (here) allowing the second delivery to get the same delivery id when calling getOutgoingDeliveryId here

My 100% reproduction scenario is as follows:

• Run artemis (2.6.2 which uses proton-j 0.27.1) with an AMQP connector
• Send a large message (10MB) to queue A
• Send a couple of small messages to queue B
• Connect a proton-c based client with a small maxFrameSize (8K) and limited credit to artemis and simultaneously subscribe to both queues (I think a flow frame triggers artemis to initiate a transfer therefore the limited credit).

With proton-c trace logging enable you will get something like this:

proton-trace.log

The attached patch fixes the issue.

proton-j-delivery-id-fix.patch

 

 

 

 

Issue Links

• is related to: ARTEMIS-1978 AMQP sequencing errors can occur when multi-frame deliveries are multiplexed on a session
• is related to: PROTON-1901 arriving transfers for multiplexed multi-frame deliveries on a session are mishandled
• is related to: QPIDJMS-405 update to proton-j 0.28.0