[PROTON-1901] arriving transfers for multiplexed multi-frame deliveries on a session are mishandled

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: proton-j-0.27.2, proton-j-0.28.0
• Fix Version/s: proton-j-0.27.3, proton-j-0.28.1
• Component/s: proton-j
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 27/Jul/18 10:48
• Updated: 07/Aug/18 15:05
• Resolved: 31/Jul/18 11:37

Description

If a session has a delivery arriving split into multiple transfer frames, and those frames are multiplexed with transfer[s] for other deliveries on the session (i.e there are multiple links on the session), then the transfer frames are mishandled.

The handling in the transport session is essentially expecting a single outstanding delivery at a time, whereas the spec allows (and proton-j will in certain situations send) multiplexed deliveries for different links on a session. The mishandling can result in a transfer being incorrectly treated as the start of another delivery (potentially leaving earlier bits/ones incomplete) and/or merged with the wrong preceding transfer content.

Issue Links

• is related to: ARTEMIS-1978 AMQP sequencing errors can occur when multi-frame deliveries are multiplexed on a session
• relates to: PROTON-1892 transfers for multiplexed deliveries on the same session can have the wrong delivery-id