[PROTON-1583] handle edge cases when driving transport#tick(now) with nanoTime derived values

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: proton-j-0.21.0
• Fix Version/s: proton-j-0.22.0
• Component/s: proton-j
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 11/Sep/17 16:33
• Updated: 24/Oct/17 08:49
• Resolved: 13/Sep/17 14:31

Description

Transport#tick is driven with time values representing 'now' in milliseconds. This is often done with System.currentTimeMillis(), however that varies with the wall clock so there are advantages to deriving the value from System.nanoTime() which does not. There are some edge cases the existing tick implementation doesn't handle when doing that (such as values wrapping and a possible clash of actual deadline zero with use of zero as a not-initialized/no-idle-timeout indicator) which could lead to incorrect behaviour and needs addressed.

Issue Links

• is related to: AMQ-6813 handle edge cases when driving transport#tick(now) with nanoTime derived values
• is related to: QPIDJMS-322 handle edge cases when driving transport#tick(now) with nanoTime derived values