Uploaded image for project: 'Qpid Proton'
  1. Qpid Proton
  2. PROTON-1583

handle edge cases when driving transport#tick(now) with nanoTime derived values

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • proton-j-0.21.0
    • proton-j-0.22.0
    • proton-j
    • None

    Description

      Transport#tick is driven with time values representing 'now' in milliseconds. This is often done with System.currentTimeMillis(), however that varies with the wall clock so there are advantages to deriving the value from System.nanoTime() which does not. There are some edge cases the existing tick implementation doesn't handle when doing that (such as values wrapping and a possible clash of actual deadline zero with use of zero as a not-initialized/no-idle-timeout indicator) which could lead to incorrect behaviour and needs addressed.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            robbie Robbie Gemmell
            robbie Robbie Gemmell
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment