[POOL-314] Return with testOnBorrow set

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.4.2
• Assignee: Unassigned
• Reporter: Tim Broberg
• Created: 16/Oct/16 07:47
• Updated: 02/Nov/16 21:01
• Resolved: 02/Nov/16 21:01

Description

On call to GenericKeyedObjectPool.returnObject() with testOnReturn set, when there are blocked GenericKeyedObjectPool.borrowObject() calls, I expect the blocked calls to unblock if returning this object successfully would free up a slot.

Instead, returnObject() exits without checking for pending borrowObject()'s.

This can result in a hung / timed out request despite the necessary resources to fill the request being available.

if (getTestOnReturn()) {
if (!factory.validateObject(key, p))

{ // blah blah blah return; }

}

// blah blah blah
if (hasBorrowWaiters())

{ reuseCapacity(); // Never get here because we returned up above. }

Issue Links

• duplicates: POOL-310 Keyed pool usage description correction