[POOL-310] Keyed pool usage description correction

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.2
• Fix Version/s: 2.4.3
• Assignee: Unassigned
• Reporter: Ivan Iliev
• Created: 02/Mar/16 18:39
• Updated: 29/Oct/17 16:07
• Resolved: 18/Mar/16 09:54

Description

This applies to GenericKeyedObjectPool.

Please consider the following situation:

1. A pool has been setup to blockWhenExhausted=true
2. maxTotal=maxTotalPerKey=1
3. no object has yet been added for any key
4. two threads are running concurrently
5. the first thread borrows key a
6. the second thread borrows key b, but fails to create an object as the pool is now full, so it gets parked
7. the first thread returns the object for its key(a) and also invalidates it

At this point we must manually unpark the second thread, which is achieved by adding a new object for the key b(possibly from the first thread). This behaviour is not described in the documentation of the pool. One could assume that at step 6, the second thread will block at the object creation and then be woken up automatically after returnObject(when the returned object also gets invalidated and destroyed).

Please add this information in the pool's description. Alternativley you could enchance the implementation to block at the creation - when the subpool is empty and there is no more space, and resume automatically from there, without the need of manual object addition.

Issue Links

• is duplicated by: POOL-314 Return with testOnBorrow set