[POOL-106] Usage of System.currentTimeMillis() as key for a TreeMap

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.3
• Fix Version/s: 1.4
• Assignee: Unassigned
• Reporter: Hauke Rabe
• Created: 16/Oct/07 06:29
• Updated: 02/May/13 02:29
• Resolved: 08/Dec/07 23:31

Description

In the method 'clearOldest' of GenericKeyedObjectPool the class ObjectTimestampPair is used as keys for a TreeMap wich compares the elements by System.currentTimeMillis().

If two ObjectTimestampPair instances have the same timestamp the value in the map will be overridden and the wrong instance will be destroyed.

If you use the pool with hibernate it will be result in a Statement already close Exception.

As a patch i return never zero in the compareTo method of ObjectTimestampPair.

Issue Links

• blocks: DBCP-201 Statement closing due to unprovoked rollback
• is depended upon by: DBCP-201 Statement closing due to unprovoked rollback