Uploaded image for project: 'Pluto'
  1. Pluto
  2. PLUTO-462

isPortletModeAllowed and isWindowStateAllowed do case-sensitve checks

    Details

      Description

      The code underlying these two methods convert the PortletMode or WindowState being checked to a string then compare it using String.equals to another string. Either PortletMode.equals and WindowState.equals need to be used or String.equalsIgnoreCase needs to be used.

        Issue Links

          Activity

          Hide
          edalquist Eric Dalquist added a comment -

          Changes the equality tests to ignore case.

          Show
          edalquist Eric Dalquist added a comment - Changes the equality tests to ignore case.
          Hide
          emetsger Elliot Metsger added a comment -

          Committed 1.1.x 611007.

          Show
          emetsger Elliot Metsger added a comment - Committed 1.1.x 611007.
          Hide
          cdoremus Craig Doremus added a comment -

          This issue needs to be resolved in the trunk (version 2.0.0) too.

          Show
          cdoremus Craig Doremus added a comment - This issue needs to be resolved in the trunk (version 2.0.0) too.
          Hide
          cdoremus Craig Doremus added a comment -

          Attached patch (modeStateEquals.patch) will not work with trunk code.

          Show
          cdoremus Craig Doremus added a comment - Attached patch (modeStateEquals.patch) will not work with trunk code.
          Hide
          emetsger Elliot Metsger added a comment -

          See PLUTO-468 for the issue opened against 2.0.0.

          Show
          emetsger Elliot Metsger added a comment - See PLUTO-468 for the issue opened against 2.0.0.
          Hide
          cdoremus Craig Doremus added a comment -

          Manually applied patch to trunk in SVN rev 679648.

          Show
          cdoremus Craig Doremus added a comment - Manually applied patch to trunk in SVN rev 679648.
          Hide
          cdoremus Craig Doremus added a comment -

          Manually applied patch to pluto-2.0-spi-refactoring branch in SVN rev 679653.

          Show
          cdoremus Craig Doremus added a comment - Manually applied patch to pluto-2.0-spi-refactoring branch in SVN rev 679653.

            People

            • Assignee:
              Unassigned
              Reporter:
              edalquist Eric Dalquist
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development