Uploaded image for project: 'Pluto'
  1. Pluto
  2. PLUTO-371 Portlet Filter
  3. PLUTO-444

Filter chain is not implemented the right way

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 1.1-286-COMPATIBILITY, 2.0.0
    • 1.1-286-COMPATIBILITY, 2.0.0
    • portal driver
    • None

    Description

      In my opinion portlet filter should work the same way like servlet filters do:

      An example: If you have a filter chain with filters F1 and F2, then the chain is: F1 -> F2 -> target -> F2 -> F1.
      An exception is, if a Filter does not call filterChain.doFilter. Then no other filter or the target is invoked and the filter itself is responsible for the response.
      (e.g. see http://java.sun.com/products/servlet/Filters.html)

      In the current implementation the target is invoked, no matter if a filter blocks the chain or not.

      Attachments

        1. filters.271107.patch
          13 kB
          Christian Raschka
        2. filter.231107.patch
          11 kB
          Christian Raschka

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            chrisra Christian Raschka
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment