Pluto
  1. Pluto
  2. PLUTO-442

Create a Testsuite for JSR-286 features

    Details

      Description

      We need to add JSR-286 (Portlet 2.0) tests to the testsuite. It might be best to create separate portlets for these tests since JSR-286 adds features that facilitate interportlet communication (eventing and public render parameters).

      This issue is a parent issue with specific tasks linked below it including PLUTO-366, PLUTO-367 and PLUTO-368 .

      1. event_tests.patch
        34 kB
        Benjamin Gould
      2. pluto-portal.patch
        1 kB
        Benjamin Gould
      3. pluto-testsuite.afewfiltertests.patch
        36 kB
        Benjamin Gould
      4. testsuite-annotations.diff
        4 kB
        Benjamin Gould
      5. testsuite-with-phase-annotations.patch
        61 kB
        Benjamin Gould

        Issue Links

          Activity

          Hide
          Ate Douma added a comment -

          Patch was applied long time ago already

          Show
          Ate Douma added a comment - Patch was applied long time ago already
          Hide
          Craig Doremus added a comment -

          Applied event_tests.patch in SVN rev 609168. Thanks Ben!

          Show
          Craig Doremus added a comment - Applied event_tests.patch in SVN rev 609168. Thanks Ben!
          Hide
          Benjamin Gould added a comment -

          Checked wrong box under "Attachment License", so I'm uploading again.

          Show
          Benjamin Gould added a comment - Checked wrong box under "Attachment License", so I'm uploading again.
          Hide
          Benjamin Gould added a comment -

          This patch (event_tests.patch) adds two new tests for eventing. Both pass for the 286-trunk-merge branch. Also, I added a simple solution for running resource serving tests (the results open in a new window). Thus, the Resource Filter Test now passes as well.

          Show
          Benjamin Gould added a comment - This patch (event_tests.patch) adds two new tests for eventing. Both pass for the 286-trunk-merge branch. Also, I added a simple solution for running resource serving tests (the results open in a new window). Thus, the Resource Filter Test now passes as well.
          Hide
          Craig Doremus added a comment -

          Thanks, Christian. testsuite-286-config.xml was added in SVN rev 604932.

          Show
          Craig Doremus added a comment - Thanks, Christian. testsuite-286-config.xml was added in SVN rev 604932.
          Hide
          Christian Raschka added a comment -

          Craig,

          i think you forgot to add testsuite-286-config.xml.

          Show
          Christian Raschka added a comment - Craig, i think you forgot to add testsuite-286-config.xml.
          Hide
          Craig Doremus added a comment -

          Commented out broken code in TestCompanionPortlet.jsp (286 Test Companion Portlet) and added text explaining the function of this portlet in SVN rev 604857

          Show
          Craig Doremus added a comment - Commented out broken code in TestCompanionPortlet.jsp (286 Test Companion Portlet) and added text explaining the function of this portlet in SVN rev 604857
          Hide
          Craig Doremus added a comment -

          Applied pluto-portal.patch and pluto-testsuite.afewfiltertests.patch in SVN revs 604407 and 604408. Fixes all testsuite tests except checkContextServerInfo (MiscTest), but most 286 tests fail and the 286 Test Companion portlet throws a JSPException as described in previous post. Thank you, Ben, for your hard work on this.

          Show
          Craig Doremus added a comment - Applied pluto-portal.patch and pluto-testsuite.afewfiltertests.patch in SVN revs 604407 and 604408. Fixes all testsuite tests except checkContextServerInfo (MiscTest), but most 286 tests fail and the 286 Test Companion portlet throws a JSPException as described in previous post. Thank you, Ben, for your hard work on this.
          Hide
          Craig Doremus added a comment -

          Applied pluto-portal.patch and pluto-testsuite.afewfiltertests.patch locally to 1.1-286-trunk-merge branch. This fixes all issues reported here https://issues.apache.org/jira/browse/PLUTO-442#action_12550045 except the last one, but the 286 Test Companion portlet on the JSR 286 Tests page errors out with this stack trace:

          javax.portlet.PortletException: javax.servlet.ServletException: javax.servlet.jsp.JspException: An error occurred while evaluating custom action attribute "test" with value "$

          {empty renderRequest.publicParameterMap}": An error occurred while getting property "publicParameterMap" from an instance of class org.apache.pluto.internal.impl.RenderRequestImpl (java.lang.UnsupportedOperationException: This method needs to be implemented.)
          at org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.internalInclude(PortletRequestDispatcherImpl.java:185)
          at org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.include(PortletRequestDispatcherImpl.java:127)
          at org.apache.pluto.testsuite.test.jsr286.TestCompanionPortlet.doView(TestCompanionPortlet.java:34)
          at javax.portlet.GenericPortlet.doDispatch(GenericPortlet.java:340)
          at javax.portlet.GenericPortlet.render(GenericPortlet.java:246)
          at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:234)
          at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)
          at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
          at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
          at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
          at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691)
          at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:594)
          at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:505)
          at org.apache.pluto.core.DefaultPortletInvokerService.invoke(DefaultPortletInvokerService.java:205)
          at org.apache.pluto.core.DefaultPortletInvokerService.render(DefaultPortletInvokerService.java:107)
          at org.apache.pluto.core.PortletContainerImpl.doRender(PortletContainerImpl.java:198)
          at org.apache.pluto.driver.tags.PortletTag.doStartTag(PortletTag.java:152)
          at org.apache.jsp.WEB_002dINF.themes.portlet_002dskin_jsp._jspx_meth_pluto_005fportlet_005f0(portlet_002dskin_jsp.java:101)
          at org.apache.jsp.WEB_002dINF.themes.portlet_002dskin_jsp._jspService(portlet_002dskin_jsp.java:76)
          at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
          at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
          at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328)
          at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
          at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
          at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
          at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
          at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691)
          at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:594)
          at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:505)
          at org.apache.jasper.runtime.JspRuntimeLibrary.include(JspRuntimeLibrary.java:965)
          at org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fforEach_005f2(pluto_002ddefault_002dtheme_jsp.java:542)
          at org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fotherwise_005f0(pluto_002ddefault_002dtheme_jsp.java:430)
          at org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fchoose_005f0(pluto_002ddefault_002dtheme_jsp.java:290)
          at org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspService(pluto_002ddefault_002dtheme_jsp.java:150)
          at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
          at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
          at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328)
          at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
          at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
          at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
          at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
          at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691)
          at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:469)
          at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:403)
          at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:301)
          at org.apache.pluto.driver.PortalDriverServlet.doGet(PortalDriverServlet.java:184)
          at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
          at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
          at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
          at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:210)
          at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174)
          at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:525)
          at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
          at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
          at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
          at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
          at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:870)
          at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665)
          at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528)
          at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81)
          at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:685)
          at java.lang.Thread.run(Thread.java:595)
          Caused by: javax.servlet.ServletException: javax.servlet.jsp.JspException: An error occurred while evaluating custom action attribute "test" with value "${empty renderRequest.publicParameterMap}

          ": An error occurred while getting property "publicParameterMap" from an instance of class org.apache.pluto.internal.impl.RenderRequestImpl (java.lang.UnsupportedOperationException: This method needs to be implemented.)
          at org.apache.jasper.runtime.PageContextImpl.doHandlePageException(PageContextImpl.java:846)
          at org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:779)
          at org.apache.jsp.jsp.TestCompanionPortlet_jsp._jspService(TestCompanionPortlet_jsp.java:119)
          at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
          at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
          at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328)
          at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
          at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
          at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
          at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
          at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691)
          at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:594)
          at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:505)
          at org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.internalInclude(PortletRequestDispatcherImpl.java:178)
          ... 65 more

          Show
          Craig Doremus added a comment - Applied pluto-portal.patch and pluto-testsuite.afewfiltertests.patch locally to 1.1-286-trunk-merge branch. This fixes all issues reported here https://issues.apache.org/jira/browse/PLUTO-442#action_12550045 except the last one, but the 286 Test Companion portlet on the JSR 286 Tests page errors out with this stack trace: javax.portlet.PortletException: javax.servlet.ServletException: javax.servlet.jsp.JspException: An error occurred while evaluating custom action attribute "test" with value "$ {empty renderRequest.publicParameterMap}": An error occurred while getting property "publicParameterMap" from an instance of class org.apache.pluto.internal.impl.RenderRequestImpl (java.lang.UnsupportedOperationException: This method needs to be implemented.) at org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.internalInclude(PortletRequestDispatcherImpl.java:185) at org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.include(PortletRequestDispatcherImpl.java:127) at org.apache.pluto.testsuite.test.jsr286.TestCompanionPortlet.doView(TestCompanionPortlet.java:34) at javax.portlet.GenericPortlet.doDispatch(GenericPortlet.java:340) at javax.portlet.GenericPortlet.render(GenericPortlet.java:246) at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:234) at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158) at javax.servlet.http.HttpServlet.service(HttpServlet.java:690) at javax.servlet.http.HttpServlet.service(HttpServlet.java:803) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188) at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691) at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:594) at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:505) at org.apache.pluto.core.DefaultPortletInvokerService.invoke(DefaultPortletInvokerService.java:205) at org.apache.pluto.core.DefaultPortletInvokerService.render(DefaultPortletInvokerService.java:107) at org.apache.pluto.core.PortletContainerImpl.doRender(PortletContainerImpl.java:198) at org.apache.pluto.driver.tags.PortletTag.doStartTag(PortletTag.java:152) at org.apache.jsp.WEB_002dINF.themes.portlet_002dskin_jsp._jspx_meth_pluto_005fportlet_005f0(portlet_002dskin_jsp.java:101) at org.apache.jsp.WEB_002dINF.themes.portlet_002dskin_jsp._jspService(portlet_002dskin_jsp.java:76) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98) at javax.servlet.http.HttpServlet.service(HttpServlet.java:803) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265) at javax.servlet.http.HttpServlet.service(HttpServlet.java:803) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188) at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691) at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:594) at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:505) at org.apache.jasper.runtime.JspRuntimeLibrary.include(JspRuntimeLibrary.java:965) at org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fforEach_005f2(pluto_002ddefault_002dtheme_jsp.java:542) at org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fotherwise_005f0(pluto_002ddefault_002dtheme_jsp.java:430) at org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fchoose_005f0(pluto_002ddefault_002dtheme_jsp.java:290) at org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspService(pluto_002ddefault_002dtheme_jsp.java:150) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98) at javax.servlet.http.HttpServlet.service(HttpServlet.java:803) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265) at javax.servlet.http.HttpServlet.service(HttpServlet.java:803) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188) at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691) at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:469) at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:403) at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:301) at org.apache.pluto.driver.PortalDriverServlet.doGet(PortalDriverServlet.java:184) at javax.servlet.http.HttpServlet.service(HttpServlet.java:690) at javax.servlet.http.HttpServlet.service(HttpServlet.java:803) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:210) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:525) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:870) at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665) at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528) at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:685) at java.lang.Thread.run(Thread.java:595) Caused by: javax.servlet.ServletException: javax.servlet.jsp.JspException: An error occurred while evaluating custom action attribute "test" with value "${empty renderRequest.publicParameterMap} ": An error occurred while getting property "publicParameterMap" from an instance of class org.apache.pluto.internal.impl.RenderRequestImpl (java.lang.UnsupportedOperationException: This method needs to be implemented.) at org.apache.jasper.runtime.PageContextImpl.doHandlePageException(PageContextImpl.java:846) at org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:779) at org.apache.jsp.jsp.TestCompanionPortlet_jsp._jspService(TestCompanionPortlet_jsp.java:119) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98) at javax.servlet.http.HttpServlet.service(HttpServlet.java:803) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265) at javax.servlet.http.HttpServlet.service(HttpServlet.java:803) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188) at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691) at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:594) at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:505) at org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.internalInclude(PortletRequestDispatcherImpl.java:178) ... 65 more
          Hide
          Craig Doremus added a comment -

          Fixed checkContextMajorVersion on MiscTest page by modifying javax.portlet.version.major in root pom.xml in SVN rev 603239.

          Show
          Craig Doremus added a comment - Fixed checkContextMajorVersion on MiscTest page by modifying javax.portlet.version.major in root pom.xml in SVN rev 603239.
          Hide
          Christian Raschka added a comment -

          There's a patch in Pluto-444 which possible make these tests working, but i havn't tested it yet.

          Show
          Christian Raschka added a comment - There's a patch in Pluto-444 which possible make these tests working, but i havn't tested it yet.
          Hide
          Benjamin Gould added a comment -

          There is a bug in the way that the test portlet determines whether or a not a batch of tests fails or passes that cropped up when I added the extra portlet lifecycle phases. Among other things, the pluto-testsuite.afewfiltertests.patch patch solves this issue.

          Show
          Benjamin Gould added a comment - There is a bug in the way that the test portlet determines whether or a not a batch of tests fails or passes that cropped up when I added the extra portlet lifecycle phases. Among other things, the pluto-testsuite.afewfiltertests.patch patch solves this issue.
          Hide
          Craig Doremus added a comment -

          Applied pluto-portal-driver-impl.urlfix.patch in PLUTO-404 and introduction_jsp.patch sent by Ben Gould to pluto-dev on 12/8/2007. in SVN rev 602887.

          The testsuite portlet now works in the 1.1-286-trunk-merge branch, but the following errors occur:

          Page: ExternalAppScopedAttributeTest
          Test: checkSetAppScopedAttributeHereSeenElsewhere
          Message: Click the provided link to validate test.

          Page: ExternalAppScopedAttributeTest
          Test: checkSetAppScopedAttributeElsewhereSeenHere
          Message: This test will not pass until you have opened the external resource using the link provided below.

          Page: SessionTimeoutTest
          Test: checkSessionInvalidated
          Message: Click the provided link to validate test.

          Page: MiscTest
          Test: checkContextMajorVersion
          Message: Assertion failed: got major version: 2, expected: 1

          Page: MiscTest
          Test: checkContextServerInfo
          Message: Error invoking checkContextServerInfo (java.lang.reflect.InvocationTargetException): null

          From what I remember, both of the ExternalAppScopedAttributeTest tests do not use a link to confirm the tests.

          Show
          Craig Doremus added a comment - Applied pluto-portal-driver-impl.urlfix.patch in PLUTO-404 and introduction_jsp.patch sent by Ben Gould to pluto-dev on 12/8/2007. in SVN rev 602887. The testsuite portlet now works in the 1.1-286-trunk-merge branch, but the following errors occur: Page: ExternalAppScopedAttributeTest Test: checkSetAppScopedAttributeHereSeenElsewhere Message: Click the provided link to validate test. Page: ExternalAppScopedAttributeTest Test: checkSetAppScopedAttributeElsewhereSeenHere Message: This test will not pass until you have opened the external resource using the link provided below. Page: SessionTimeoutTest Test: checkSessionInvalidated Message: Click the provided link to validate test. Page: MiscTest Test: checkContextMajorVersion Message: Assertion failed: got major version: 2, expected: 1 Page: MiscTest Test: checkContextServerInfo Message: Error invoking checkContextServerInfo (java.lang.reflect.InvocationTargetException): null From what I remember, both of the ExternalAppScopedAttributeTest tests do not use a link to confirm the tests.
          Hide
          Benjamin Gould added a comment -

          This patch adds the JSR 286 test portlet along with its companion portlet to the default pages of the Pluto portal.

          Show
          Benjamin Gould added a comment - This patch adds the JSR 286 test portlet along with its companion portlet to the default pages of the Pluto portal.
          Hide
          Benjamin Gould added a comment -

          Here are few portlet filter tests, as well as a refactoring of the test suite's portlet.xml to reference the Portlet 2.0 deployment descriptor XSD. Temporarily its schemaLocation points to the server hosting the latest version of the spec. Will change this in the future when the XSD is available somewhere else online.

          The portlet filter tests are failing in both the trunk-merge and 286-COMPATIBILITY branches. Could someone please verify the status of the portlet filter implementations in these branches (i.e., do I have things set up incorrectly, or is the functionality simply not there)?

          This patch also provided another that displays the current public render parameters and in the future will keep track of events that are fired for the eventing tests. This portlet throws an exception right now because RenderRequest.getPublicParameterMap() is unimplemented.

          Show
          Benjamin Gould added a comment - Here are few portlet filter tests, as well as a refactoring of the test suite's portlet.xml to reference the Portlet 2.0 deployment descriptor XSD. Temporarily its schemaLocation points to the server hosting the latest version of the spec. Will change this in the future when the XSD is available somewhere else online. The portlet filter tests are failing in both the trunk-merge and 286-COMPATIBILITY branches. Could someone please verify the status of the portlet filter implementations in these branches (i.e., do I have things set up incorrectly, or is the functionality simply not there)? This patch also provided another that displays the current public render parameters and in the future will keep track of events that are fired for the eventing tests. This portlet throws an exception right now because RenderRequest.getPublicParameterMap() is unimplemented.
          Hide
          Benjamin Gould added a comment -

          I forgot to add the annotations package to subversion in my local working copy, so they weren't included in my first patch. Sorry.

          Show
          Benjamin Gould added a comment - I forgot to add the annotations package to subversion in my local working copy, so they weren't included in my first patch. Sorry.
          Hide
          Craig Doremus added a comment -

          Applied testsuite-with-phase-annotations.patch to 1.1-286-trunk-merge branch in SVN rev 598245. Thank you Ben.

          Show
          Craig Doremus added a comment - Applied testsuite-with-phase-annotations.patch to 1.1-286-trunk-merge branch in SVN rev 598245. Thank you Ben.
          Hide
          Craig Doremus added a comment -

          Applied testsuite-with-phase-annotations.patch to 1.1-286-COMPATIBILITY branch in SVN rev 598238. Thank you Ben.

          Show
          Craig Doremus added a comment - Applied testsuite-with-phase-annotations.patch to 1.1-286-COMPATIBILITY branch in SVN rev 598238. Thank you Ben.
          Hide
          Craig Doremus added a comment - - edited

          Applied pluto-testsuite changes from 1.1-286-trunk-merge to 1.1-286-COMPATIBILITY branch in SVN rev 598004 to allow testing of patches applied to this issue in a working pluto-driver since 1.1-286-trunk-merge is still in the middle of refactoring. The only old code kept in the 1.1-286-COMPATIBILITY branch is the hard coded values in pluto-testsuite/src/main/resources/expectedResults.properties since the Maven 2 build has not been modified in this branch to use variables in this file.

          Show
          Craig Doremus added a comment - - edited Applied pluto-testsuite changes from 1.1-286-trunk-merge to 1.1-286-COMPATIBILITY branch in SVN rev 598004 to allow testing of patches applied to this issue in a working pluto-driver since 1.1-286-trunk-merge is still in the middle of refactoring. The only old code kept in the 1.1-286-COMPATIBILITY branch is the hard coded values in pluto-testsuite/src/main/resources/expectedResults.properties since the Maven 2 build has not been modified in this branch to use variables in this file.
          Hide
          Benjamin Gould added a comment -

          This patch updates the test suite so that JSR 286 test may more easily be written against the testing framework. This patch adds the following features:

          1) Each portlet test can implement a doHeaders() function (default does nothing) that gets called by TestPortlet.doHeaders()

          2) Annotations have been added to define the portlet lifecycle phase in which each test method should run. If a class is not annotated, the default phase is Render. The @DefaultTestPhase annotation causes all test methods on a PortletTest implementation to be run in the given phase, unless an individual method is annotated with @TestPhase, in which case the default is overriden.

          3) Test methods can now have signatures that have specific sub-interfaces of PortletRequest (before, all test methods could only have arguments containing PortletRequest or PortletResponse, rather than RenderRequest, ActionRequest, etc.) Obviously, the test method signature must agree with the phase denoted by its annotation(s). For backwards compatibility, test methods can still have signatures containing PortletRequest or PortletResponse.

          4) Updated all interfaces and implementations with generics and removed compiler warning related to Java 5 language features.

          Show
          Benjamin Gould added a comment - This patch updates the test suite so that JSR 286 test may more easily be written against the testing framework. This patch adds the following features: 1) Each portlet test can implement a doHeaders() function (default does nothing) that gets called by TestPortlet.doHeaders() 2) Annotations have been added to define the portlet lifecycle phase in which each test method should run. If a class is not annotated, the default phase is Render. The @DefaultTestPhase annotation causes all test methods on a PortletTest implementation to be run in the given phase, unless an individual method is annotated with @TestPhase, in which case the default is overriden. 3) Test methods can now have signatures that have specific sub-interfaces of PortletRequest (before, all test methods could only have arguments containing PortletRequest or PortletResponse, rather than RenderRequest, ActionRequest, etc.) Obviously, the test method signature must agree with the phase denoted by its annotation(s). For backwards compatibility, test methods can still have signatures containing PortletRequest or PortletResponse. 4) Updated all interfaces and implementations with generics and removed compiler warning related to Java 5 language features.

            People

            • Assignee:
              Unassigned
              Reporter:
              Craig Doremus
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development