Pig
  1. Pig
  2. PIG-3760 Predicate pushdown for columnar file formats
  3. PIG-4102

Adding e2e tests and several improvements for Orc predicate pushdown

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0
    • Component/s: impl
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. PIG-4102-2.patch
      19 kB
      Daniel Dai
    2. PIG-4102-1.patch
      18 kB
      Daniel Dai

      Activity

      Hide
      Daniel Dai added a comment -

      The patch fixed Orc PPD for bigdecimal/timestamp (pending HIVE-7222, PIG-4128), also add e2e tests.

      Show
      Daniel Dai added a comment - The patch fixed Orc PPD for bigdecimal/timestamp (pending HIVE-7222 , PIG-4128 ), also add e2e tests.
      Hide
      Rohini Palaniswamy added a comment -

      +1

      Two minor changes to be done before checkin
      1) I had put kryo as test->master in ivy.xml. Can you change to compile->master?
      2) exec to exec; in e2e tests. Also leave one or two tests without exec; . Had done that intentionally initially as no multiquery is to execute on store statement and wanted to have that also in the test.

      Show
      Rohini Palaniswamy added a comment - +1 Two minor changes to be done before checkin 1) I had put kryo as test->master in ivy.xml. Can you change to compile->master? 2) exec to exec; in e2e tests. Also leave one or two tests without exec; . Had done that intentionally initially as no multiquery is to execute on store statement and wanted to have that also in the test.
      Hide
      Daniel Dai added a comment -

      Fix boolean PPD pending HIVE-7818.

      Address Rohini's comment 1). For 2), I add "exec" due to PIG-4130. It pass before due to PIG-4106.

      Show
      Daniel Dai added a comment - Fix boolean PPD pending HIVE-7818 . Address Rohini's comment 1). For 2), I add "exec" due to PIG-4130 . It pass before due to PIG-4106 .
      Hide
      Rohini Palaniswamy added a comment -

      +1

      Show
      Rohini Palaniswamy added a comment - +1
      Hide
      Daniel Dai added a comment -

      Patch committed to trunk. Thanks Rohini for review!

      Show
      Daniel Dai added a comment - Patch committed to trunk. Thanks Rohini for review!

        People

        • Assignee:
          Daniel Dai
          Reporter:
          Daniel Dai
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development