Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. PIG-3760-initial.patch
      93 kB
      Rohini Palaniswamy
    2. PIG-4091-1.patch
      98 kB
      Rohini Palaniswamy
    3. PIG-4091-diffwithinitial.patch
      24 kB
      Rohini Palaniswamy

      Activity

      Hide
      Rohini Palaniswamy added a comment -

      Attached initial patch. Still has some pending TODOs

      • Add e2e tests
      • Add tests for datatypes - boolean, byte, short, biginteger, bigdecimal, datetime

      LoadPredicatePushdown interface needs some more enhancements. Filed PIG-4093 and PIG-4094 for that.

      Show
      Rohini Palaniswamy added a comment - Attached initial patch. Still has some pending TODOs Add e2e tests Add tests for datatypes - boolean, byte, short, biginteger, bigdecimal, datetime LoadPredicatePushdown interface needs some more enhancements. Filed PIG-4093 and PIG-4094 for that.
      Hide
      Daniel Dai added a comment -

      The patch is already in good shape. All tests pass for me. I would like to commit as is and we can add e2e tests and finish up TODOs in followup Jiras.

      Show
      Daniel Dai added a comment - The patch is already in good shape. All tests pass for me. I would like to commit as is and we can add e2e tests and finish up TODOs in followup Jiras.
      Hide
      Daniel Dai added a comment -

      Patch committed to trunk. Filed PIG-4102 for followup work. Thanks Rohini!

      Show
      Daniel Dai added a comment - Patch committed to trunk. Filed PIG-4102 for followup work. Thanks Rohini!
      Hide
      Rohini Palaniswamy added a comment -

      The patch attached in reviewboard was not uploaded in jira as jira was being reindexed and not available at that time. Attached the patch from reviewboard (PIG-4091-1.patch) and committed the diff between the review board patch and PIG-3760-initial.patch (PIG-4091-diffwithinitial.patch) in to trunk.

      Show
      Rohini Palaniswamy added a comment - The patch attached in reviewboard was not uploaded in jira as jira was being reindexed and not available at that time. Attached the patch from reviewboard ( PIG-4091 -1.patch) and committed the diff between the review board patch and PIG-3760 -initial.patch ( PIG-4091 -diffwithinitial.patch) in to trunk.

        People

        • Assignee:
          Rohini Palaniswamy
          Reporter:
          Rohini Palaniswamy
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development