Pig
  1. Pig
  2. PIG-3779

Assert constructs ConstantExpression with null when no comment is given

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.1, 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      I ran into this problem with Lipstick after deploying ASSERT. When ASSERT is not given any comment, LogicalPlanBuilder constructs ConstantExpression with null. Later tools like Lipstick try to convert it to a String resulting in NPE.

      Although it's possible to handle this case in Lipstick, I feel ConstantExpression shouldn't be constructed with null in the first place.

      Here is the code in LogicalPlanBuilder-

      ConstantExpression constExpr = new ConstantExpression(exprPlan, comment);
      
      1. assert.diff
        0.9 kB
        Jacob Perkins

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Jacob Perkins
            Reporter:
            Cheolsoo Park
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development