Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-3779

Assert constructs ConstantExpression with null when no comment is given

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.12.1, 0.13.0
    • None
    • None

    Description

      I ran into this problem with Lipstick after deploying ASSERT. When ASSERT is not given any comment, LogicalPlanBuilder constructs ConstantExpression with null. Later tools like Lipstick try to convert it to a String resulting in NPE.

      Although it's possible to handle this case in Lipstick, I feel ConstantExpression shouldn't be constructed with null in the first place.

      Here is the code in LogicalPlanBuilder-

      ConstantExpression constExpr = new ConstantExpression(exprPlan, comment);
      

      Attachments

        1. assert.diff
          0.9 kB
          Jacob Perkins

        Activity

          People

            thedatachef Jacob Perkins
            cheolsoo Cheolsoo Park
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: