Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11
    • Component/s: None
    • Labels:
      None

      Description

      TestIndexedStorage is failing because it is not properly creating the output directory. I've refactored it to use real temp directories instead of something in the root.

      1. PIG-2737-1.patch
        4 kB
        Jonathan Coveney
      2. PIG-2737-0.patch
        4 kB
        Jonathan Coveney

        Activity

        Hide
        Jonathan Coveney added a comment -

        The issue that I noticed was that it was creating a directory "out" in the piggybank directory, and it was failing to make the proper files. I simplified the code and just had it write/read to/from a temporary directory.

        Show
        Jonathan Coveney added a comment - The issue that I noticed was that it was creating a directory "out" in the piggybank directory, and it was failing to make the proper files. I simplified the code and just had it write/read to/from a temporary directory.
        Hide
        Julien Le Dem added a comment -

        Sounds good to me Jonathan. Thanks for cleaning that up.
        some comments:

        • System.out.println => Logger.debug
        • you should still cleanup the output dir @After the test
        Show
        Julien Le Dem added a comment - Sounds good to me Jonathan. Thanks for cleaning that up. some comments: System.out.println => Logger.debug you should still cleanup the output dir @After the test
        Hide
        Jonathan Coveney added a comment -

        Julien, I took your comments into account. What do you think?

        Show
        Jonathan Coveney added a comment - Julien, I took your comments into account. What do you think?
        Hide
        Jonathan Coveney added a comment -

        Bump

        Show
        Jonathan Coveney added a comment - Bump
        Hide
        Julien Le Dem added a comment -

        +1

        Show
        Julien Le Dem added a comment - +1

          People

          • Assignee:
            Jonathan Coveney
            Reporter:
            Jonathan Coveney
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development