[PHOENIX-6861] PQS fails to start because of relocated javax.servlet with Phoenix 5.2

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: queryserver-6.0.1
• Fix Version/s: queryserver-6.0.1
• Component/s: queryserver
• Release Note: Due to an incompatible change in the way phoenix-client is shaded and relocated, when using PQS with Phoenix 5.1.0 - 5.1.3 or 4.16.x, PQS must be built with the "shade-javax-servlet" maven profile enabled.
• Assignee: Istvan Toth
• Reporter: Istvan Toth
• Created: 24/Jan/23 11:53
• Updated: 09/Feb/23 18:42
• Resolved: 27/Jan/23 07:30

Description

We've made to relatively recent changes to javax.servelt in the shaded PQS client JAR.
In PHOENIX-6151 we've applied shading to it, then in PHOENIX-6703 we've removed it altogether from the embedded client JAR.

Also relatively recently, we have added a dependency for org.apache.hadoop.jmx.JMXJsonServlet to PQS.

As a result, we have mutually incompatible requirements for the PQS classpath.

For old phoenix-client versions, and for current 5.2 phoenix-client versions with PHOENIX-6703, we need to have unshaded javax.servlet, both for Avatica, and for JMXJsonServlet on the classpath.

On the other hand, for Phoenix versions that have PHOENIX-6151, but not PHOENIX-6703, we need to shade javax.servlet so that it matches with shading applied for JMXJsonServlet (which is coming via phoenix-client, which shades javax.servlet).

We need to find some kind of solution to this mess, ideally so that the same PQS binary works with as many Phoenix versions as possible.

Issue Links

• is caused by: PHOENIX-6703 Exclude Jetty and servlet-api from phoenix-client
• is duplicated by: PHOENIX-6605 Cancel the shade relocation on javax.servlet
• is related to: PHOENIX-6294 javax.servlet relocation added by PHOENIX-6151 breaks PQS
• links to: GitHub Pull Request #115