[PHOENIX-6151] Switch phoenix-client to shade-by-default mode

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1.0, 4.16.0
• Fix Version/s: 5.1.0, 4.16.0
• Component/s: core
• Assignee: Istvan Toth
• Reporter: Istvan Toth
• Created: 22/Sep/20 08:26
• Updated: 04/Jan/21 10:14
• Resolved: 17/Oct/20 20:56

Description

Phoenix-client contains Phoenix, plus most of a Hadoop+Hbase stack.

We keep running into difficulties, where phoenix-client conflicts with user code, or in the case of connectors with different components.

Instead of shading packages explicitly, try the approach of shading everything, and only keeping unshaded the libraries that cannot be shaded.

This is the approach taken by Hadoop.

Issue Links

• causes: PHOENIX-6221 Getting CNF while creating transactional table with Omid
• causes: PHOENIX-6193 PHOENIX-6151 slows down shading
• causes: PHOENIX-6294 javax.servlet relocation added by PHOENIX-6151 breaks PQS
• is depended upon by: PHOENIX-6144 Phoenix client coexistence with other hadoop components in the same JVM
• is related to: PHOENIX-6175 Sort out phoenix-connectors shading for 6.0
• is related to: PHOENIX-6053 Split Server Side Code into a Separate Module
• relates to: PHOENIX-6089 Additional relocations for the 5.1.0 client
• relates to: PHOENIX-6114 Create shaded phoenix-pherf and remove lib dir from assembly
• links to: GitHub Pull Request #890