Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-5454

Phoenix scripts start foreground java processes as child processes

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.15.0, 5.1.0
    • Fix Version/s: 5.1.0, 4.16.0
    • Labels:
      None

      Description

      Currently the phoenix scripts in python start the java process via subprocess.call() or subprocess.popen() even when the java process has to run in the foreground, and there is no cleanup required.

      I propose that in these cases, we start java via os.exec*(). This has the following advantages:

      • There is no python process idling waiting for the java process to end, reducing process count and memory consumption
      • Signal handling is simplified (signals sent to the starting script are received by the java process started)
      • Return code handling is simplified (no need to check for and return error codes from java in the startup script)

        Attachments

        1. PHOENIX-5454.master.v1.patch
          5 kB
          Istvan Toth
        2. PHOENIX-5454.master.v2.patch
          5 kB
          Istvan Toth

          Activity

            People

            • Assignee:
              stoty Istvan Toth
              Reporter:
              stoty Istvan Toth
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m