[PHOENIX-5454] Phoenix scripts start foreground java processes as child processes

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.15.0, 5.1.0
• Fix Version/s: 5.1.0, queryserver-6.0.0, 4.16.0
• Component/s: core, queryserver
• Assignee: Istvan Toth
• Reporter: Istvan Toth
• Created: 27/Aug/19 14:00
• Updated: 03/Aug/21 08:35
• Resolved: 14/Jan/20 08:47

Description

Currently the phoenix scripts in python start the java process via subprocess.call() or subprocess.popen() even when the java process has to run in the foreground, and there is no cleanup required.

I propose that in these cases, we start java via os.exec*(). This has the following advantages:

• There is no python process idling waiting for the java process to end, reducing process count and memory consumption
• Signal handling is simplified (signals sent to the starting script are received by the java process started)
• Return code handling is simplified (no need to check for and return error codes from java in the startup script)

Issue Links

• links to: GitHub Pull Request #9
• links to: GitHub Pull Request #573