[PHOENIX-1826] Implement TrackOrderPreservingExpressionCompiler as Expression visitor instead of ParseNode visitor

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.4.0
• Assignee: James R. Taylor
• Reporter: James R. Taylor
• Created: 08/Apr/15 21:01
• Updated: 21/Nov/15 02:15
• Resolved: 14/Apr/15 00:17

Description

We currently traverse the ORDER BY ParseNodes in TrackOrderPreservingExpressionCompiler to determine if the rows will be ordered in row key order. This complicates supporting ORDER BY expressions that are an ordinal position (PHOENIX-1749), since it's a fair bit of code to manufacture a ParseNode when wildcards are used in the select. We should consider writing this visitor as an Expression instead and then using ordinal position would be easy as we could index into the RowProjector to get an Expression. See ViewWhereExpressionVisitor in CreateTableCompiler for an example.