Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-1826

Implement TrackOrderPreservingExpressionCompiler as Expression visitor instead of ParseNode visitor

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4.0
    • Component/s: None
    • Labels:
      None

      Description

      We currently traverse the ORDER BY ParseNodes in TrackOrderPreservingExpressionCompiler to determine if the rows will be ordered in row key order. This complicates supporting ORDER BY expressions that are an ordinal position (PHOENIX-1749), since it's a fair bit of code to manufacture a ParseNode when wildcards are used in the select. We should consider writing this visitor as an Expression instead and then using ordinal position would be easy as we could index into the RowProjector to get an Expression. See ViewWhereExpressionVisitor in CreateTableCompiler for an example.

        Attachments

        1. PHOENIX-1826.patch
          62 kB
          James R. Taylor
        2. PHOENIX-1826.patch
          83 kB
          James R. Taylor
        3. PHOENIX-1826-combined.patch
          84 kB
          James R. Taylor

          Activity

            People

            • Assignee:
              jamestaylor James R. Taylor
              Reporter:
              jamestaylor James R. Taylor
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: