[PDFBOX-1803] StringIndexOutOfBound on DateConverter.toCalendar

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.3
• Fix Version/s: 1.8.5
• Component/s: PDModel, Utilities
• Assignee: Unassigned
• Reporter: Eric Leleu
• Created: 09/Dec/13 13:42
• Updated: 17/Mar/16 19:13
• Resolved: 11/Oct/14 00:18

Description

Some PDF have an empty string as CreationDate & ModDate in the Information Dictionary.

According to the PDF specification, this two element are optional.

My first fix was to test the null & the empty string in the toCalendar(String, String[]) method and I return null if one of the both condition is verified.
But according to a test case(TestDateUtil) a NullPointer is expected on null value of text. Can you explain why this behaviour has been adopted?

To fixe this unexpected exception in my execution path, I have added a test on the empty string in the deprecated method toCalendar(String). (Patch in attachment)

I'm waiting your comment before commit this patch (or change it by my first implementation)

BR,
Eric

Issue Links

• is depended upon by: TIKA-1233 PDFBox can throw StringIndexOutOfBoundsException on some dates
• is required by: PDFBOX-1684 DateConverter source is in three places and has diverged