Uploaded image for project: 'PDFBox'
  1. PDFBox
  2. PDFBOX-1684

DateConverter source is in three places and has diverged

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0.0
    • Fix Version/s: None
    • Component/s: Utilities
    • Labels:
    • Environment:
      Win 8, maven 3.0.5, svn 1.7.8 (r1419691), javac 1.7.0_25

      Description

      Versions of DateConverter,java are in three (3) packages: jempbox.impl, pdfbox.util, and xmpbox. They have diverged as updates have been made to one or the other.

      Date Converter is used in these modules:
      jempbox.xmp.ResourceEvent.java
      jempbox.xmp.XMPSchema.java
      pdfbox.cos.COSDictionary.java
      pdfbox.pdmodel.fdf.FDFAnnotation.java
      preflight.metadata.SynchronizedMetaDataValidation.java
      xmpbox.type.DateType.java

      The smallest library is xmpbox, so let's consider it as a home for DateConverter. Preflight already imports xmpbox. Pdfbox requires jempbox, so importing xmpbox into jempbox will satisfy both. Since xmpbox defines some xmp features, it seems likely that jempbox could take further advantage of xmpbox.

      { incorrect: Conclusion and recommendation: have a single copy of DateConverter in xmpbox. }

      Conclusion: create another top-level pdfbox package for DateConverter and other utilities that do not depend on pdfbox classes.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                zweibieren Fred Hansen
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: