[PDFBOX-1684] DateConverter source is in three places and has diverged

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.0.0
• Component/s: Utilities
• Labels: Breaking-Change
• Environment: Win 8, maven 3.0.5, svn 1.7.8 (r1419691), javac 1.7.0_25
• Assignee: Unassigned
• Reporter: Fred Hansen
• Created: 07/Aug/13 14:44
• Updated: 03/Feb/15 19:12

Description

Versions of DateConverter,java are in three (3) packages: jempbox.impl, pdfbox.util, and xmpbox. They have diverged as updates have been made to one or the other.

Date Converter is used in these modules:
jempbox.xmp.ResourceEvent.java
jempbox.xmp.XMPSchema.java
pdfbox.cos.COSDictionary.java
pdfbox.pdmodel.fdf.FDFAnnotation.java
preflight.metadata.SynchronizedMetaDataValidation.java
xmpbox.type.DateType.java

The smallest library is xmpbox, so let's consider it as a home for DateConverter. Preflight already imports xmpbox. Pdfbox requires jempbox, so importing xmpbox into jempbox will satisfy both. Since xmpbox defines some xmp features, it seems likely that jempbox could take further advantage of xmpbox.

{ incorrect: Conclusion and recommendation: have a single copy of DateConverter in xmpbox. }

Conclusion: create another top-level pdfbox package for DateConverter and other utilities that do not depend on pdfbox classes.

Issue Links

• requires: PDFBOX-1803 StringIndexOutOfBound on DateConverter.toCalendar