[ORC-1021] Add -fno-omit-frame-pointer in RELWITHDEBINFO build

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.2
• Fix Version/s: 1.7.2
• Component/s: build, C++
• Assignee: Quanlong Huang
• Reporter: Quanlong Huang
• Created: 08/Oct/21 02:24
• Updated: 02/Feb/22 23:55
• Resolved: 09/Oct/21 22:53

Description

David Rorke points out that it'd be helpful to add the -fno-omit-frame-pointer option in release builds, which helps to generate flame graphs for deep stacks [1]. 

The option is already used in release builds of Impala and we found the performance penalty is small (IMPALA-4132). As we have two release modes, i.e. RELEASE and RELWITHDEBINFO with symbols, we can add this option to RELWITHDEBINFO builds.

[1]: https://www.brendangregg.com/perf.html#StackTraces

Issue Links

• is required by: IMPALA-10917 Consider building native toolchain with -fno-omit-frame-pointer
• links to: GitHub Pull Request #932