Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-1021

Add -fno-omit-frame-pointer in RELWITHDEBINFO build

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.8.0
    • 1.7.2
    • build, C++
    • None

    Description

      drorke points out that it'd be helpful to add the -fno-omit-frame-pointer option in release builds, which helps to generate flame graphs for deep stacks [1]

      The option is already used in release builds of Impala and we found the performance penalty is small (IMPALA-4132). As we have two release modes, i.e. RELEASE and RELWITHDEBINFO with symbols, we can add this option to RELWITHDEBINFO builds.

      [1]: https://www.brendangregg.com/perf.html#StackTraces

      Attachments

        Issue Links

          Activity

            People

              stigahuang Quanlong Huang
              stigahuang Quanlong Huang
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: