Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4132

Consider using -fno-omit-frame-pointer in release builds

    Details

      Description

      We're currently building with -fomit-frame-pointer, which can lead to cryptic stack traces.

      Switching to -fno-omit-frame-pointer will produce better stack traces but cost some performance. In my past experience, on x86-64 the penalty was around 0.5% (though on different code and with a different register allocator) which I think is a reasonably tradeoff but in corner cases it can be higher. So we'd need to qualify this change through a perf regression run (both benchmarks and primitives).

        Attachments

        1. targeted_report.txt
          12 kB
          Gabor Kaszab
        2. tpcds_report.txt
          7 kB
          Gabor Kaszab
        3. tpcds_unmodified_report.txt
          36 kB
          Gabor Kaszab
        4. tpch_nested_report.txt
          5 kB
          Gabor Kaszab
        5. tpch_report.txt
          6 kB
          Gabor Kaszab

          Activity

            People

            • Assignee:
              gaborkaszab Gabor Kaszab
              Reporter:
              srus Silvius Rus
            • Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: