Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-M2
    • Fix Version/s: 2.0.0-M2
    • Component/s: query
    • Labels:
      None

      Description

      Include additional junit tests for setting the query timeout property via Persistence.createEntityManagerFactory(Map properties) and PU properties in persistence.xml.
      Need to add a test showing that a PU or Map provided query timeout does not affect EM.find()/findAll() operations.

      1. OPENJPA-963.patch
        42 kB
        Donald Woods

        Issue Links

          Activity

          Donald Woods created issue -
          Donald Woods made changes -
          Field Original Value New Value
          Affects Version/s 2.0.0 [ 12313483 ]
          Fix Version/s 2.0.0 [ 12313483 ]
          Description Include additional junit tests for setting the QueryHint property via Persistence.createEntityManagerFactory and persistence.xml
          Component/s query [ 12311309 ]
          Donald Woods made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Donald Woods made changes -
          Link This issue depends on OPENJPA-972 [ OPENJPA-972 ]
          Hide
          Donald Woods added a comment -

          Depends on persistence3.xml added by OPENJPA-972

          Show
          Donald Woods added a comment - Depends on persistence3.xml added by OPENJPA-972
          Donald Woods made changes -
          Summary Add query timeout tests for properties Add query timeout tests for PU and Map properties
          Description Include additional junit tests for setting the QueryHint property via Persistence.createEntityManagerFactory and persistence.xml Include additional junit tests for setting the query timeout property via Persistence.createEntityManagerFactory(Map properties) and PU properties in persistence.xml.
          Need to add a test showing that a PU or Map provided query timeout does not affect EM.find()/findAll() operations.
          Hide
          Donald Woods added a comment -

          Patch that adds addition PU/Map tests for query timeout and cleans up some existing tests and comments provided by OPENJPA-878 and OPENJPA-972.
          Updates DBDictionary.setQueryTimeout() by:
          1) handling special timeout=-1 case, by converting it to JDBC expected 0
          2) adding new log message for timeout < -1, which will not be set
          3) adding new setQueryTimeoutDB() method as requested by Fay

          Show
          Donald Woods added a comment - Patch that adds addition PU/Map tests for query timeout and cleans up some existing tests and comments provided by OPENJPA-878 and OPENJPA-972 . Updates DBDictionary.setQueryTimeout() by: 1) handling special timeout=-1 case, by converting it to JDBC expected 0 2) adding new log message for timeout < -1, which will not be set 3) adding new setQueryTimeoutDB() method as requested by Fay
          Donald Woods made changes -
          Attachment OPENJPA-963.patch [ 12402599 ]
          Hide
          Donald Woods added a comment -

          Fay, can you review and commit this patch, as it includes your requested DBDictionary.setQueryTimeoutDB() method?

          Show
          Donald Woods added a comment - Fay, can you review and commit this patch, as it includes your requested DBDictionary.setQueryTimeoutDB() method?
          Donald Woods made changes -
          Assignee Donald Woods [ drwoods ] Fay Wang [ faywang ]
          Donald Woods made changes -
          Assignee Fay Wang [ faywang ] Donald Woods [ drwoods ]
          Hide
          Donald Woods added a comment -

          Committed to trunk as Rev756193 by Fay.

          Show
          Donald Woods added a comment - Committed to trunk as Rev756193 by Fay.
          Donald Woods made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Donald Woods made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue depends on OPENJPA-972 [ OPENJPA-972 ]
          Gavin made changes -
          Link This issue depends upon OPENJPA-972 [ OPENJPA-972 ]

            People

            • Assignee:
              Donald Woods
              Reporter:
              Donald Woods
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development