Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 1.3.0, 2.0.0-M3
    • Component/s: jdbc
    • Labels:
      None
    • Environment:
      Ingres Database 9.2
    • Patch Info:
      Patch Available

      Description

      DBDictionary subclass for Ingres Database

      There are no Sub-Tasks for this issue.

        Activity

        Hide
        Milosz Tylenda added a comment -

        Alan, would you like to contribute a dictionary for Ingres or just wish OpenJPA shipped with one?

        Show
        Milosz Tylenda added a comment - Alan, would you like to contribute a dictionary for Ingres or just wish OpenJPA shipped with one?
        Hide
        Alan Raison added a comment -

        Milosz, apologies for this JIRA not being resolved. I have been developing a dictionary for Ingres and have just been waiting for the JDBC driver to make it into the central maven repository before I submit it.

        It should just be a week or so now.

        Show
        Alan Raison added a comment - Milosz, apologies for this JIRA not being resolved. I have been developing a dictionary for Ingres and have just been waiting for the JDBC driver to make it into the central maven repository before I submit it. It should just be a week or so now.
        Hide
        Alan Raison added a comment -

        I have sent in a CLA today, so here is my contribution (finally!)

        Some issues to note are that:

        • the JDBC driver still isn't in the main maven repository, although I am hoping that this will happen soon, as it's been on the list for ages.
        • The unit tests take a long time to run (several hours) - we've looked into this and not really been able to speed it up. It seems to take a long time in the mapping tool and there are also some performance issues with the JDBC driver in other areas

        I hope that it's otherwise ok; perhaps people might be able to offer their thoughts on how to improve it.

        Alan

        Show
        Alan Raison added a comment - I have sent in a CLA today, so here is my contribution (finally!) Some issues to note are that: the JDBC driver still isn't in the main maven repository, although I am hoping that this will happen soon, as it's been on the list for ages. The unit tests take a long time to run (several hours) - we've looked into this and not really been able to speed it up. It seems to take a long time in the mapping tool and there are also some performance issues with the JDBC driver in other areas I hope that it's otherwise ok; perhaps people might be able to offer their thoughts on how to improve it. Alan
        Hide
        Donald Woods added a comment -

        Which version(s) of Ingres did you test against and did all of the junit tests in openjpa-persistence-jdbc pass?

        Show
        Donald Woods added a comment - Which version(s) of Ingres did you test against and did all of the junit tests in openjpa-persistence-jdbc pass?
        Hide
        Alan Raison added a comment -

        Sorry there are still a few unit test errors - I will get back to you if and when I have questions about how to fix them!

        Show
        Alan Raison added a comment - Sorry there are still a few unit test errors - I will get back to you if and when I have questions about how to fix them!
        Hide
        Alan Raison added a comment -

        I have got the pass rate to 93%:

        Tests 2069
        Errors 62
        Failures 73
        Skipped 0
        Success Rate 93.475%
        Time 51,567.418

        I also ran the tests against another non-derby database, and its results were similar (93.9% pass). In the "release early, release often" spirit, could this be included in the main code? Hopefully this will allow more testers to get involved.

        Show
        Alan Raison added a comment - I have got the pass rate to 93%: Tests 2069 Errors 62 Failures 73 Skipped 0 Success Rate 93.475% Time 51,567.418 I also ran the tests against another non-derby database, and its results were similar (93.9% pass). In the "release early, release often" spirit, could this be included in the main code? Hopefully this will allow more testers to get involved.
        Hide
        Donald Woods added a comment -

        Sure, please attach a patch for trunk (or 1.3.x) and I'll try to get it committed.

        Show
        Donald Woods added a comment - Sure, please attach a patch for trunk (or 1.3.x) and I'll try to get it committed.
        Hide
        Alan Raison added a comment -

        I'm just having some problems with DBCP - connections don't seem to be reused or closed. I'll look into this first.

        Thanks

        Alan

        Show
        Alan Raison added a comment - I'm just having some problems with DBCP - connections don't seem to be reused or closed. I'll look into this first. Thanks Alan
        Hide
        Alan Raison added a comment -

        It appears that the test suite uses a new pool for each persistence-unit (which makes sense) so there aren't any problems with that.

        I will just run the tests again through DBCP and then submit my patch.

        Show
        Alan Raison added a comment - It appears that the test suite uses a new pool for each persistence-unit (which makes sense) so there aren't any problems with that. I will just run the tests again through DBCP and then submit my patch.
        Hide
        Alan Raison added a comment -

        IngresDictionary & Associated changes for review

        Show
        Alan Raison added a comment - IngresDictionary & Associated changes for review
        Hide
        Michael Dick added a comment -

        Thanks for the patch Alan. I do not have access to Ingres, so I'm relying on your tests for that database.

        Also I could use some help with the manual for Ingres, there are a couple of sections where I just guessed (known problems, connection URL). If you or someone familiar with Ingres could take a look at OPENJPA-1246 that would be most helpful.

        Show
        Michael Dick added a comment - Thanks for the patch Alan. I do not have access to Ingres, so I'm relying on your tests for that database. Also I could use some help with the manual for Ingres, there are a couple of sections where I just guessed (known problems, connection URL). If you or someone familiar with Ingres could take a look at OPENJPA-1246 that would be most helpful.

          People

          • Assignee:
            Michael Dick
            Reporter:
            Alan Raison
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development