Uploaded image for project: 'OpenJPA'
  1. OpenJPA
  2. OPENJPA-896

Several source files include Windows EoL chars

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 1.0.3, 1.1.0, 1.2.0
    • 1.0.4, 1.2.2, 1.3.0, 2.0.0-M2
    • docs
    • None

    Description

      Several of the doc files include the Windows Ctrl+M chars at the end of lines when checked out to non-Windows platforms (like MacOSX and Linux), due to the committer not using the ASF suggested svn config values - http://www.apache.org/dev/svn-eol-style.txt

      From http://www.apache.org/dev/version-control.html -
      Configuring the Subversion client

      Committers will need to properly configure their svn client. One particular issue is OS-specific line-endings for text files. When you add a new text file, especially when applying patches from Bugzilla, first ensure that the line-endings are appropriate for your system, then do ...

      svn add test.txt
      svn propset svn:eol-style native test.txt

      Your svn client can be configured to do that automatically for some common file types. Add the contents of the file http://www.apache.org/dev/svn-eol-style.txt to your ~/.subversion/config file. [Note: for Windows this is normally found at C:\Documents and Settings\{username}\Application Data\Subversion\config]

      Some files may need additional properties to be set, for example svn:executable=* should be applied to those script files (e.g. .bat, .cgi, .cmd, .sh) that are intended to be executed. Since not all such files are necessarily intended to be executed, the executable property should not be made an automatic default.

      However, you should still pay attention to the messages from your svn client when you do 'svn commit'.

      Attachments

        1. OPENJPA-896-trunk.patch
          406 kB
          Donald Woods
        2. OPENJPA-896-trunk-withprops.patch
          411 kB
          Donald Woods

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mikedd Michael Dick
            drwoods Donald Woods
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment