OpenJPA
  1. OpenJPA
  2. OPENJPA-887

Assertion oversight in TestLibService

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3.0, 2.0.0-M1, 2.0.0-M2
    • Fix Version/s: 1.3.0, 2.0.0-M2
    • Component/s: None
    • Labels:
      None

      Description

      There is a small but quite nasty oversight in TestLibService class:

      assertNotNull("could not find the reference from " + bName + "'s volunteer status back to " + bName, volunteer.getBorrower() == borrower);

      I suspect the intention was to have assertTrue(...). The above compiles because of autoboxing creating a Boolean but the assertion is always true, even if volunteer.getBorrower() != borrower.

      1. OPENJPA-887.patch
        0.8 kB
        Milosz Tylenda

        Activity

        Hide
        Milosz Tylenda added a comment -

        Thanks, Mike. I was aware of this "revert property" feature but was not sure whether I should use this.

        Actually, only trunk commit was without a message, the 1.3.x commit had a message but it does not matter now.

        Show
        Milosz Tylenda added a comment - Thanks, Mike. I was aware of this "revert property" feature but was not sure whether I should use this. Actually, only trunk commit was without a message, the 1.3.x commit had a message but it does not matter now.
        Hide
        Michael Dick added a comment -

        No worries Milosz. I've gone ahead and corrected the svn log settings for both releases.

        FWIW you can do this by running the following commands :

        $ svn ps -r 759470 --revprop svn:log "OPENJPA-887" https://svn.apache.org/repos/asf/openjpa/trunk

        $ svn ps -r 759473 --revprop svn:log "OPENJPA-887" https://svn.apache.org/repos/asf/openjpa/branches/1.3.x/

        The SVN FAQ has complete documentation at http://subversion.tigris.org/faq.html#change-log-msg.

        Obviously you're not the first to do this

        Show
        Michael Dick added a comment - No worries Milosz. I've gone ahead and corrected the svn log settings for both releases. FWIW you can do this by running the following commands : $ svn ps -r 759470 --revprop svn:log " OPENJPA-887 " https://svn.apache.org/repos/asf/openjpa/trunk $ svn ps -r 759473 --revprop svn:log " OPENJPA-887 " https://svn.apache.org/repos/asf/openjpa/branches/1.3.x/ The SVN FAQ has complete documentation at http://subversion.tigris.org/faq.html#change-log-msg . Obviously you're not the first to do this
        Hide
        Milosz Tylenda added a comment -

        The patch applied to trunk and 1.3.x branch.

        I am sorry the trunk commit went without message - I made a kind of "do-it-first-time" mistake. The trunk revision is 759470.

        Show
        Milosz Tylenda added a comment - The patch applied to trunk and 1.3.x branch. I am sorry the trunk commit went without message - I made a kind of "do-it-first-time" mistake. The trunk revision is 759470.
        Hide
        Milosz Tylenda added a comment -

        The patch is attached.

        Show
        Milosz Tylenda added a comment - The patch is attached.

          People

          • Assignee:
            Milosz Tylenda
            Reporter:
            Milosz Tylenda
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development