OpenJPA
  1. OpenJPA
  2. OPENJPA-781

openjpa-jdbc depends on postgres driver, should be "provided"

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-M2
    • Fix Version/s: 1.3.0, 2.0.0-M2
    • Component/s: build / infrastructure
    • Labels:
      None

      Description

      just need to add <scope>provided</scope> to the postgres sql dependency.

      Index: openjpa-jdbc/pom.xml
      ===================================================================
      — openjpa-jdbc/pom.xml (revision 720348)
      +++ openjpa-jdbc/pom.xml (working copy)
      @@ -47,12 +47,13 @@
      <dependency>
      <groupId>hsqldb</groupId>
      <artifactId>hsqldb</artifactId>

      • <scope>compile</scope>
        + <scope>provided</scope>
        </dependency>
        <dependency>
        <groupId>postgresql</groupId>
        <artifactId>postgresql</artifactId>
        <version>8.1-407.jdbc3</version>
        + <scope>provided</scope>
        </dependency>
        </dependencies>
        <build>
      1. pom.xml.diff
        4 kB
        Fernando Padilla

        Activity

        Hide
        Michael Dick added a comment -

        Thanks for the patch. There's a lot of opportunity for cleanup in the pom.xml files I'm sure.

        Show
        Michael Dick added a comment - Thanks for the patch. There's a lot of opportunity for cleanup in the pom.xml files I'm sure.
        Hide
        Fernando Padilla added a comment -

        this is actually a bigger diff of cleaning up the scopes of more pom files..

        some dependencies are set to be "compile" when they really are hard dependencies ( runtime ), and some dependencies are compile when they should be "provided" so that they are not actually required unless the end-user explicitly uses them ( hsqldb, postgresql, etc )

        Show
        Fernando Padilla added a comment - this is actually a bigger diff of cleaning up the scopes of more pom files.. some dependencies are set to be "compile" when they really are hard dependencies ( runtime ), and some dependencies are compile when they should be "provided" so that they are not actually required unless the end-user explicitly uses them ( hsqldb, postgresql, etc )

          People

          • Assignee:
            Michael Dick
            Reporter:
            Fernando Padilla
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development