OpenJPA
  1. OpenJPA
  2. OPENJPA-778

cleaning up build for openjpa-kernel

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0, 2.0.0-M2
    • Component/s: kernel
    • Labels:
      None

      Description

      I am trying to get started developing on OpenJPA, and I found some minor issues here and there. Attached is a simple patch to apply to openjpa-kernel, cleaning up how it generates the jjtree-javacc sources.

      1. openjpa-kernel.diff
        10 kB
        Fernando Padilla

        Activity

        Fernando Padilla created issue -
        Hide
        Fernando Padilla added a comment -

        This patch modifies the pom.xml of openjpa-kernel.

        It also expects for you to move a file:

        svn mv src/main/java/org/apache/openjpa/kernel/jpql/ParseException.java src/main/jjtree/org/apache/openjpa/kernel/jpql/ParseException.java

        This way the ParseException.java overrides that one which is being generated. So that javacc doesn't generate a new one (and force us to delete it later ).

        Show
        Fernando Padilla added a comment - This patch modifies the pom.xml of openjpa-kernel. It also expects for you to move a file: svn mv src/main/java/org/apache/openjpa/kernel/jpql/ParseException.java src/main/jjtree/org/apache/openjpa/kernel/jpql/ParseException.java This way the ParseException.java overrides that one which is being generated. So that javacc doesn't generate a new one (and force us to delete it later ).
        Fernando Padilla made changes -
        Field Original Value New Value
        Attachment openjpa-kernel.diff [ 12394395 ]
        Michael Dick made changes -
        Assignee Michael Dick [ mikedd ]
        Hide
        Michael Dick added a comment -

        Thanks for the patch!

        Show
        Michael Dick added a comment - Thanks for the patch!
        Michael Dick made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.3.0 [ 12313326 ]
        Fix Version/s 2.0.0 [ 12313483 ]
        Resolution Fixed [ 1 ]
        Donald Woods made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        18h 32m 1 Michael Dick 21/Nov/08 21:30
        Resolved Resolved Closed Closed
        472d 21h 1 Donald Woods 09/Mar/10 18:31

          People

          • Assignee:
            Michael Dick
            Reporter:
            Fernando Padilla
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development