Uploaded image for project: 'OpenJPA'
  1. OpenJPA
  2. OPENJPA-670

Discriminator column is missing from table when inheritance is used without annotation

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.2.0, 1.3.0
    • 1.2.0, 1.3.0
    • jdbc
    • None

    Description

      According to the EJB 3.0 JPA spec (pp. 191, section 9.1.29):

      "If the Inheritance annotation is not specified or if no inheritance type is specified for an entity class
      hierarchy, the SINGLE_TABLE mapping strategy is used."

      I've found that if an entity inheritance hierarchy is specified without an explicit DiscriminatorColumn or Inheritance annotation, a single table will be used for mapping, but there will be no discriminator column in the table.

      pp. 191 - 192, section 9.1.30 of the spec reads:

      "For the SINGLE_TABLE mapping strategy, and typically also for the JOINED strategy, the persistence
      provider will use a type discriminator column."

      and

      "If the DiscriminatorColumn annotation is missing, and a discriminator column is required, the
      name of the discriminator column defaults to "DTYPE" and the discriminator type to STRING."

      Without a discriminator column a scenario such as:

      entity B extends entity A
      entity C extends entity A

      "select c from C" will return entities of type A, B, and C (which is a data integrity issue) because there is no way to distinguish between the entity types.

      The simple workaround is to specify an @Inheritance or @DiscriminatorColumn annotation on the root class, but OpenJPA should exhibit default behavior defined by the spec when these annotations are not specified.

      I have a patch and jUnits in the works and will post them shortly.

      Attachments

        1. openjpa-670.patch
          82 kB
          Jeremy Bauer

        Activity

          People

            techhusky Jeremy Bauer
            techhusky Jeremy Bauer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: