OpenJPA
  1. OpenJPA
  2. OPENJPA-670

Discriminator column is missing from table when inheritance is used without annotation

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: jdbc
    • Labels:
      None

      Description

      According to the EJB 3.0 JPA spec (pp. 191, section 9.1.29):

      "If the Inheritance annotation is not specified or if no inheritance type is specified for an entity class
      hierarchy, the SINGLE_TABLE mapping strategy is used."

      I've found that if an entity inheritance hierarchy is specified without an explicit DiscriminatorColumn or Inheritance annotation, a single table will be used for mapping, but there will be no discriminator column in the table.

      pp. 191 - 192, section 9.1.30 of the spec reads:

      "For the SINGLE_TABLE mapping strategy, and typically also for the JOINED strategy, the persistence
      provider will use a type discriminator column."

      and

      "If the DiscriminatorColumn annotation is missing, and a discriminator column is required, the
      name of the discriminator column defaults to "DTYPE" and the discriminator type to STRING."

      Without a discriminator column a scenario such as:

      entity B extends entity A
      entity C extends entity A

      "select c from C" will return entities of type A, B, and C (which is a data integrity issue) because there is no way to distinguish between the entity types.

      The simple workaround is to specify an @Inheritance or @DiscriminatorColumn annotation on the root class, but OpenJPA should exhibit default behavior defined by the spec when these annotations are not specified.

      I have a patch and jUnits in the works and will post them shortly.

      1. openjpa-670.patch
        82 kB
        Jeremy Bauer

        Activity

        Hide
        Jeremy Bauer added a comment -

        Attaching patch containing fix and jUnits for trunk (currently 1.3.0). Please review and if no comments, commit for trunk and 1.2.x.

        In case it isn't clear from the code and comments, the update to PersistenceTestCase is to clean up tables used by managed interfaces. They are by definition abstract and were being skipped during the cleanup process.

        Show
        Jeremy Bauer added a comment - Attaching patch containing fix and jUnits for trunk (currently 1.3.0). Please review and if no comments, commit for trunk and 1.2.x. In case it isn't clear from the code and comments, the update to PersistenceTestCase is to clean up tables used by managed interfaces. They are by definition abstract and were being skipped during the cleanup process.
        Hide
        Michael Dick added a comment -

        Fixed in trunk and 1.2.x

        Show
        Michael Dick added a comment - Fixed in trunk and 1.2.x

          People

          • Assignee:
            Jeremy Bauer
            Reporter:
            Jeremy Bauer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development