OpenJPA
  1. OpenJPA
  2. OPENJPA-617

Use of hardcoded DB platform strings should be avoided

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      This is a bad practice in the code that I recently put in.
      Hard-coded "Oracle" string should be avoided.

        Activity

        Hide
        Catalina Wei added a comment -

        1. The hard coded "Oracle" String has been removed.
        2. Not all jdbc driver have the connection APIs available.
        Tthe trace info for the initial connection propertities are only available to JDBC 3 drivers.
        For this reaon, this particular message trace is removed from DataSourceFactory,
        but placed in DBDictionary.
        Because of this move, some message text has be relocated into org.apache.openjpa.jdbc.sql package.

        Show
        Catalina Wei added a comment - 1. The hard coded "Oracle" String has been removed. 2. Not all jdbc driver have the connection APIs available. Tthe trace info for the initial connection propertities are only available to JDBC 3 drivers. For this reaon, this particular message trace is removed from DataSourceFactory, but placed in DBDictionary. Because of this move, some message text has be relocated into org.apache.openjpa.jdbc.sql package.

          People

          • Assignee:
            Catalina Wei
            Reporter:
            Catalina Wei
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development