[OPENJPA-487] Generated SUBSTRING SQL is ugly and inefficient

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.0, 0.9.6, 0.9.7, 1.0.0, 1.0.1, 1.0.2, 1.1.0
• Fix Version/s: 2.2.0
• Component/s: sql
• Assignee: Milosz Tylenda
• Reporter: Patrick Linskey
• Created: 16/Jan/08 01:38
• Updated: 02/Feb/12 16:24
• Resolved: 20/Jul/11 19:45

Description

When performing a JPQL query with a SUBSTRING clause, OpenJPA converts from one-based index + length parameters to zero-based index + end index for internal handling, and then re-converts back to one-based + length when generating SQL. This conversion is entirely performed in query values, so the generated SQL has a lot of math in it. This extra math is never necessary.

Issue Links

• incorporates: OPENJPA-488 Simplify JPQL SUBSTRING clauses involving literal index and position data