[OPENJPA-437] EntityManagerFactory is not thread-safe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0, 1.0.1, 1.0.2, 1.1.0
• Fix Version/s: 1.0.2, 1.1.0
• Component/s: kernel
• Assignee: Kevin W. Sutter
• Reporter: Kevin W. Sutter
• Created: 08/Nov/07 14:23
• Updated: 27/Mar/08 20:23
• Resolved: 25/Jan/08 21:52

Description

Under certain conditions, we have discovered that the EntityManagerFactory is not thread safe when creating EntityManagers. The problem is in the loadPersistentTypes method of the AbstractBrokerFactory. There is an unprotected data structure (_pcClassNames) that can various problems (NullPointerException, IndexOutOfBoundsException, etc) when attempting to add new elements to the ArrayList. Other similar datastructures in this part are properly synchronized (_pcClassLoaders for example), but somehow we missed this one.

A common scenario where this might be encountered is if your SLSB has an injected PersistenceUnit (EntityManagerFactory), but is attempting to create the EntityManager during a post-bean creation method (@PostConstruct). In this case, the SLSB instances are probably using the same EMF instance (of course this would depend on your application server implementation). If you have this type of environment, then hitting these SLSB's with multiple clients could get you into this situation.

Issue Links

• is duplicated by: OPENJPA-449 Under concurrent access, createEntityManager() fails with NPE.