OpenJPA
  1. OpenJPA
  2. OPENJPA-331

Allow BigInteger and other Basic types as Primary Keys

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.7, 1.0.0
    • Fix Version/s: 1.0.2, 1.1.0
    • Component/s: kernel
    • Labels:
      None

      Description

      Section 2.1.4 of the JPA spec outlines the requirements for a primary key (@Id):

      Section 2.1.4: A simple ( i.e., non-composite) primary key must correspond to a single persistent field or property of
      the entity class. The Id annotation is used to denote a simple primary key. See section 9.1.8.

      Also from Section 2.1.4 : The primary key (or field or property of a composite primary key) should be one of the following types:
      any Java primitive type; any primitive wrapper type; java.lang.String; java.util.Date;
      java.sql.Date. In general, however, approximate numeric types (e.g., floating point types) should
      never be used in primary keys. Entities whose primary keys use types other than these will not be portable.
      If generated primary keys are used, only integral types will be portable. If java.util.Date is
      used as a primary key field or property, the temporal type should be specified as DATE.

      Right now, we are treating the "should be" statement above as "must be" and only allowing the specified types as primary keys. But, the sentence in the middle of this paragraph ("Entities whose primary keys use types other than these will not be portable.") indicates that other types can also be allowed, but may not be portable.

      It seems that Glassfish allows these additional Basic types as primary keys. We should probably allow the same thing to keep up with the Jones'.

      This was discussed on dev mailing list. http://www.nabble.com/BigInteger-as-%40Id-tf4318071.html

      1. fix-OpenJPA-331.patch
        19 kB
        Miroslav Nachev
      2. license-fix-OpenJPA-331-v110.patch
        12 kB
        Miroslav Nachev
      3. license-fix-OpenJPA-331-v110.patch
        12 kB
        Miroslav Nachev
      4. license-fix-OpenJPA-331-v110.patch
        12 kB
        Miroslav Nachev

        Activity

        Kevin Sutter created issue -
        Kevin Sutter made changes -
        Field Original Value New Value
        Fix Version/s 1.1.0 [ 12312344 ]
        Fix Version/s 1.0.1 [ 12312687 ]
        Affects Version/s 1.0.0 [ 12312341 ]
        Albert Lee made changes -
        Fix Version/s 1.0.1 [ 12312687 ]
        Fix Version/s 1.0.2 [ 12312846 ]
        Miroslav Nachev made changes -
        Attachment fix-OpenJPA-331.patch [ 12371662 ]
        Miroslav Nachev made changes -
        Attachment license-fix-OpenJPA-331-v110.patch [ 12371932 ]
        Miroslav Nachev made changes -
        Attachment license-fix-OpenJPA-331-v110.patch [ 12371933 ]
        Miroslav Nachev made changes -
        Attachment license-fix-OpenJPA-331-v110.patch [ 12372010 ]
        Patrick Linskey made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Donald Woods made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Kevin Sutter
            Reporter:
            Kevin Sutter
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development