Uploaded image for project: 'OpenJPA'
  1. OpenJPA
  2. OPENJPA-2795

generate foreign key indexes for Oracle

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.3, 3.1.0
    • Fix Version/s: 3.2.0
    • Component/s: jdbc
    • Labels:
      None

      Description

      When generating a schema SQL via OpenJPA then we do omit the CREATE INDEX if there is a Forein Key CONSTRAINT generated.

      For the following please consider an Entity CarLicensePlate which has a @ManyToOne on Customer.

      Without giving any further generator options we generate the correct CREATE INDEX statement:

      CREATE TABLE CUSTOMER (ID NUMBER NOT NULL, active VARCHAR(1), name VARCHAR2(255), PRIMARY KEY (ID));
      CREATE TABLE LIC_PLATE (id VARCHAR2(255) NOT NULL, maker VARCHAR2(255), model VARCHAR2(255), optLock NUMBER, CUSTOMER_ID NUMBER, PRIMARY KEY (id));
      CREATE INDEX I_LIC_PLT_CUSTOMER ON LIC_PLATE (CUSTOMER_ID);
      

      But once we switch on explicit foreign key constraints via

      <MappingDefaults>ForeignKeyDeleteAction=restrict, JoinForeignKeyDeleteAction=restrict</MappingDefaults>
      

      then the index is omitted.

      CREATE TABLE CUSTOMER (ID NUMBER NOT NULL, active VARCHAR(1), name VARCHAR2(255), PRIMARY KEY (ID));
      CREATE TABLE LIC_PLATE (id VARCHAR2(255) NOT NULL, maker VARCHAR2(255), model VARCHAR2(255), optLock NUMBER, CUSTOMER_ID NUMBER, PRIMARY KEY (id));
      ALTER TABLE LIC_PLATE ADD FOREIGN KEY (CUSTOMER_ID) REFERENCES CUSTOMER (ID) DEFERRABLE;
      

      This is ok for most databases as a foreign key constraint they usually automatically internally create an index as well. But sadly this is not the case for Oracle. Here we would actually need both, the constraint and the index.

      There is even an own switch IndexLogicalForeignKeys in MappingDefaults. But this doesn't really do what we need right now in this case. It's more a switch to disable index creating even if there is no constraints.

      We could either introduce a new flag in MappingDefaults or change the IndexLogicalForeignKeys from boolean to Boolean or even an enum with a FORCED.
      Even better would be a DbDictionary specific handling. That way we could create the index automatically for Oracle while skipping it for others.

        Attachments

          Activity

            People

            • Assignee:
              struberg Mark Struberg
              Reporter:
              struberg Mark Struberg
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: