Uploaded image for project: 'OpenJPA'
  1. OpenJPA
  2. OPENJPA-2675

Missing check for null parameter in equals()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.4.2, 3.0.0
    • Component/s: None
    • Labels:
      None

      Description

      In classes CandidatePath at line 184,CriteriaQueryImpl at line 738, Extensions at line 440 and StoreFacadeTypeRegistry at line 108 there is equals method that there is no check for null parameter.
      According javadoc for Object equals method:
      For any non-null reference value x, x.equals(null) should return false.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1768191 from Mark Struberg in branch 'openjpa/trunk'
        [ https://svn.apache.org/r1768191 ]

        OPENJPA-2675 implement null-check for CriteriaQueryImpl#equals

        txs to Kaloyan Spiridonov for the catch!

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1768191 from Mark Struberg in branch 'openjpa/trunk' [ https://svn.apache.org/r1768191 ] OPENJPA-2675 implement null-check for CriteriaQueryImpl#equals txs to Kaloyan Spiridonov for the catch!
        Hide
        struberg Mark Struberg added a comment -

        txs for the catch!

        Show
        struberg Mark Struberg added a comment - txs for the catch!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1768200 from Mark Struberg in branch 'openjpa/branches/2.4.x'
        [ https://svn.apache.org/r1768200 ]

        OPENJPA-2675 implement null-check for CriteriaQueryImpl#equals

        txs to Kaloyan Spiridonov for the catch!

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1768200 from Mark Struberg in branch 'openjpa/branches/2.4.x' [ https://svn.apache.org/r1768200 ] OPENJPA-2675 implement null-check for CriteriaQueryImpl#equals txs to Kaloyan Spiridonov for the catch!
        Hide
        ilgrosso Francesco Chicchiriccò added a comment -

        Bulk close for 2.4.2

        Show
        ilgrosso Francesco Chicchiriccò added a comment - Bulk close for 2.4.2

          People

          • Assignee:
            struberg Mark Struberg
            Reporter:
            kal0ian Kaloyan Spiridonov
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development