[OPENJPA-2674] JarFile is not closed

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.1
• Fix Version/s: 2.4.2, 3.0.0
• Assignee: Mark Struberg
• Reporter: Kaloyan Spiridonov
• Created: 18/Oct/16 11:48
• Updated: 03/Jan/17 07:37
• Resolved: 05/Nov/16 11:33

Description

In InstrumentationFactory class at line 375 JarFile is not closed.

 private static boolean validateAgentJarManifest(File agentJarFile, Log log,
        String agentClassName) {
        try {
            JarFile jar = new JarFile(agentJarFile);
            Manifest manifest = jar.getManifest();
            if (manifest == null) {
                return false;
            }
            Attributes attributes = manifest.getMainAttributes();
            String ac = attributes.getValue("Agent-Class");
            if (ac != null && ac.equals(agentClassName)) {
                return true;
            }
        } catch (Exception e) {
            if (log.isTraceEnabled() == true) {
                log.trace(_name
                    + ".validateAgentJarManifest() caught unexpected "
                    + "exception " + e.getMessage());
            }
        }
        return false;
    }