Uploaded image for project: 'OpenJPA'
  1. OpenJPA
  2. OPENJPA-2617

blacklist org.codehaus.groovy.runtime.,org.apache.commons.collections.functors.,org.apache.xalan in our custom ObjectInputStreams

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.4.1
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 1716859 from Romain Manni-Bucau in branch 'openjpa/trunk'
      [ https://svn.apache.org/r1716859 ]

      OPENJPA-2617 adding BlacklistClassResolver to support blacklisting of class loading in our ObjectInputStream

      Show
      jira-bot ASF subversion and git services added a comment - Commit 1716859 from Romain Manni-Bucau in branch 'openjpa/trunk' [ https://svn.apache.org/r1716859 ] OPENJPA-2617 adding BlacklistClassResolver to support blacklisting of class loading in our ObjectInputStream
      Hide
      jpaheath Heath Thomann added a comment -

      Hi Romain! This commit causes the following build/checkstyle issue:

      [INFO] Starting audit...
      E:\jpa\openJPAcode\trunk\openjpa-kernel\src\main\java\org\apache\openjpa\util\BlacklistClassResolver.java:0: File does not end with a newline.
      Audit done.

      [INFO] ------------------------------------------------------------------------
      [ERROR] BUILD ERROR
      [INFO] ------------------------------------------------------------------------
      [INFO] An error has occurred in Checkstyle report generation.

      Show
      jpaheath Heath Thomann added a comment - Hi Romain! This commit causes the following build/checkstyle issue: [INFO] Starting audit... E:\jpa\openJPAcode\trunk\openjpa-kernel\src\main\java\org\apache\openjpa\util\BlacklistClassResolver.java:0: File does not end with a newline. Audit done. [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] An error has occurred in Checkstyle report generation.
      Hide
      romain.manni-bucau Romain Manni-Bucau added a comment -

      Heath Thomann how did you get this? I ran the normal profile without issues. That said fixed this one.

      Show
      romain.manni-bucau Romain Manni-Bucau added a comment - Heath Thomann how did you get this? I ran the normal profile without issues. That said fixed this one.
      Hide
      dazeydev Will Dazey added a comment -

      I am getting the same failure with "mvn clean install" on the trunk.

      [INFO] Processed 1 grammar
      [INFO]
      [INFO] — maven-checkstyle-plugin:2.6:checkstyle (default) @ openjpa-kernel —

      [INFO] Starting audit...
      C:\JPA\OPENJPA\trunk\openjpa-kernel\src\main\java\org\apache\openjpa\util\Blackl
      istClassResolver.java:0: File does not end with a newline.
      Audit done.

      [INFO] ------------------------------------------------------------------------
      [INFO] Reactor Summary:
      [INFO]
      [INFO] OpenJPA Parent POM ................................ SUCCESS [24.766s]
      [INFO] OpenJPA Utilities Library ......................... SUCCESS [13.426s]
      [INFO] OpenJPA Kernel .................................... FAILURE [3.004s]

      Show
      dazeydev Will Dazey added a comment - I am getting the same failure with "mvn clean install" on the trunk. [INFO] Processed 1 grammar [INFO] [INFO] — maven-checkstyle-plugin:2.6:checkstyle (default) @ openjpa-kernel — [INFO] Starting audit... C:\JPA\OPENJPA\trunk\openjpa-kernel\src\main\java\org\apache\openjpa\util\Blackl istClassResolver.java:0: File does not end with a newline. Audit done. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] OpenJPA Parent POM ................................ SUCCESS [24.766s] [INFO] OpenJPA Utilities Library ......................... SUCCESS [13.426s] [INFO] OpenJPA Kernel .................................... FAILURE [3.004s]
      Hide
      romain.manni-bucau Romain Manni-Bucau added a comment -

      Just tested again, my local copy is clean and I don't get this issue:

      [INFO] ------------------------------------------------------------------------
      [INFO] Building OpenJPA Kernel 2.4.1-SNAPSHOT
      [INFO] ------------------------------------------------------------------------
      [INFO]
      [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ openjpa-kernel ---
      [INFO] Deleting /Users/rmannibu/dev/apache/openjpa-trunk/openjpa-kernel/target
      [INFO]
      [INFO] --- buildnumber-maven-plugin:1.0-beta-4:create (default) @ openjpa-kernel ---
      [INFO]
      [INFO] --- maven-enforcer-plugin:1.3.1:enforce (default) @ openjpa-kernel ---
      [INFO]
      [INFO] --- javacc-maven-plugin:2.4:jjtree-javacc (jjtree-javacc-jpql) @ openjpa-kernel ---
      Java Compiler Compiler Version 4.0 (Tree Builder)
      (type "jjtree" with no arguments for help)
      Reading from file /Users/rmannibu/dev/apache/openjpa-trunk/openjpa-kernel/src/main/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jjt . . .
      File "/Users/rmannibu/dev/apache/openjpa-trunk/openjpa-kernel/target/generated-sources/jjtree/org/apache/openjpa/kernel/jpql/Node.java" does not exist.  Will create one.
      Annotated grammar generated successfully in /Users/rmannibu/dev/apache/openjpa-trunk/openjpa-kernel/target/generated-sources/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jj
      Java Compiler Compiler Version 4.0 (Parser Generator)
      (type "javacc" with no arguments for help)
      Reading from file /Users/rmannibu/dev/apache/openjpa-trunk/openjpa-kernel/target/generated-sources/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jj . . .
      Warning: Choice conflict in (...)* construct at line 939, column 17.
               Expansion nested within construct and expansion following construct
               have common prefixes, one of which is: "+"
               Consider using a lookahead of 2 or more for nested expansion.
      Warning: Choice conflict in (...)* construct at line 948, column 17.
               Expansion nested within construct and expansion following construct
               have common prefixes, one of which is: "*"
               Consider using a lookahead of 2 or more for nested expansion.
      File "TokenMgrError.java" does not exist.  Will create one.
      Warning: ParseException.java: File is obsolete.  Please rename or delete this file so that a new one can be generated for you.
      File "Token.java" does not exist.  Will create one.
      File "JavaCharStream.java" does not exist.  Will create one.
      Parser generated with 0 errors and 3 warnings.
      [INFO] Processed 1 grammar
      [INFO]
      [INFO] --- maven-checkstyle-plugin:2.6:checkstyle (default) @ openjpa-kernel ---
      [INFO] Starting audit...
      Audit done.
      
      [WARNING] Unable to locate Source XRef to link to - DISABLED
      [INFO]
      [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ openjpa-kernel ---
      

      also checked manually last line was empty

      Show
      romain.manni-bucau Romain Manni-Bucau added a comment - Just tested again, my local copy is clean and I don't get this issue: [INFO] ------------------------------------------------------------------------ [INFO] Building OpenJPA Kernel 2.4.1-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-clean-plugin:2.5:clean ( default -clean) @ openjpa-kernel --- [INFO] Deleting /Users/rmannibu/dev/apache/openjpa-trunk/openjpa-kernel/target [INFO] [INFO] --- buildnumber-maven-plugin:1.0-beta-4:create ( default ) @ openjpa-kernel --- [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce ( default ) @ openjpa-kernel --- [INFO] [INFO] --- javacc-maven-plugin:2.4:jjtree-javacc (jjtree-javacc-jpql) @ openjpa-kernel --- Java Compiler Compiler Version 4.0 (Tree Builder) (type "jjtree" with no arguments for help) Reading from file /Users/rmannibu/dev/apache/openjpa-trunk/openjpa-kernel/src/main/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jjt . . . File "/Users/rmannibu/dev/apache/openjpa-trunk/openjpa-kernel/target/generated-sources/jjtree/org/apache/openjpa/kernel/jpql/Node.java" does not exist. Will create one. Annotated grammar generated successfully in /Users/rmannibu/dev/apache/openjpa-trunk/openjpa-kernel/target/generated-sources/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jj Java Compiler Compiler Version 4.0 (Parser Generator) (type "javacc" with no arguments for help) Reading from file /Users/rmannibu/dev/apache/openjpa-trunk/openjpa-kernel/target/generated-sources/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jj . . . Warning: Choice conflict in (...)* construct at line 939, column 17. Expansion nested within construct and expansion following construct have common prefixes, one of which is: "+" Consider using a lookahead of 2 or more for nested expansion. Warning: Choice conflict in (...)* construct at line 948, column 17. Expansion nested within construct and expansion following construct have common prefixes, one of which is: "*" Consider using a lookahead of 2 or more for nested expansion. File "TokenMgrError.java" does not exist. Will create one. Warning: ParseException.java: File is obsolete. Please rename or delete this file so that a new one can be generated for you. File "Token.java" does not exist. Will create one. File "JavaCharStream.java" does not exist. Will create one. Parser generated with 0 errors and 3 warnings. [INFO] Processed 1 grammar [INFO] [INFO] --- maven-checkstyle-plugin:2.6:checkstyle ( default ) @ openjpa-kernel --- [INFO] Starting audit... Audit done. [WARNING] Unable to locate Source XRef to link to - DISABLED [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process ( default ) @ openjpa-kernel --- also checked manually last line was empty
      Hide
      dazeydev Will Dazey added a comment -

      The issue seems to be that you have created this new file and do not have your svn client configured for OS-nonspecific EOL characters. Check out this JIRA for details on a similar issue: https://issues.apache.org/jira/browse/OPENJPA-896

      Show
      dazeydev Will Dazey added a comment - The issue seems to be that you have created this new file and do not have your svn client configured for OS-nonspecific EOL characters. Check out this JIRA for details on a similar issue: https://issues.apache.org/jira/browse/OPENJPA-896

        People

        • Assignee:
          Unassigned
          Reporter:
          romain.manni-bucau Romain Manni-Bucau
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development