[OPENJPA-2507] Weird EmptyStackException in CriteriaQueryImpl

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.0, 2.3.0, 2.4.0
• Fix Version/s: 2.4.0
• Component/s: criteria
• Labels: criteria_api openjpa
• Environment: openjpa 2.2.0 & 2.3.0, spring-data-jpa up to 1.4.2
• Assignee: Kevin W. Sutter
• Reporter: Ioannis Alexandrakis
• Created: 27/May/14 20:57
• Updated: 06/Jun/15 14:25
• Resolved: 09/Jul/14 16:15

Description

Using spring-data-jpa with openjpa, I sometimes encounter a strange error (not all the times, but under heavy load it makes its appearance, sparsely though):
....
Caused by: java.util.EmptyStackException
at java.util.Stack.peek(Stack.java:<arbitrary line>)
at org.apache.openjpa.persistence.criteria.CriteriaQueryImpl.ctx(CriteriaQueryImpl.java:<arbitrary line>
....

I do not know which behaviour triggers it, however I think it would be an improvement to change (I did not know where exactly to file it, because it is both an improvement and a bug in my opinion), in org.apache.openjpa.persistence.criteria.CriteriaQueryImpl, method: Context ctx(), this:
return _contexts == null || _contexts.isEmpty() ? null : _contexts.peek();
to something like this:
try {
return _contexts == null || _contexts.isEmpty() ? null : _contexts.peek();
} catch (EmptyStackException e) {
return null;
}

, in order to prevent a case where multiple threads modify the "_contexts" between the evaluation of the inline "if".

I am not able to reproduce it all the time, thus I can't create a useful test, neither have I created a patch due to the simplicity of the 'fix'. However I believe it is a harmless fix which could be considered a minor improvement.

Issue Links

• is related to: OPENJPA-2098 Criteria Query fails with empty context statck