OpenJPA
  1. OpenJPA
  2. OPENJPA-2410

Build time detection of System.out/err.print(ln) in source files

    Details

    • Patch Info:
      Patch Available

      Description

      Source files may have inadvertent System.out/err.print statements left in source files on commit. Ideally we don't want any of these changes being checked in and a large majority of the time logging facilities should be utilized. That being said, there are a number of cases where we don't have access to a logger and must use System.out/err.

      This JIRA will be used to update our checkstyle to scan for unwanted print statements, and fail the build when/if they are encountered.

      1. OPENJPA-2410.2.2.x.patch
        26 kB
        Rick Curtis
      2. OPENJPA-2410.1.2.x.patch
        15 kB
        Rick Curtis
      3. OPENJPA-2410r2.patch
        1 kB
        Di Wu Lau
      4. OPENJPA-2410r1.patch
        0.9 kB
        Di Wu Lau
      5. OPENJPA-2410.patch
        7 kB
        Di Wu Lau

        Activity

        Mark Struberg made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Rick Curtis made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Rick Curtis made changes -
        Fix Version/s 2.1.2 [ 12317142 ]
        Rick Curtis made changes -
        Attachment OPENJPA-2410.1.2.x.patch [ 12595756 ]
        Attachment OPENJPA-2410.2.2.x.patch [ 12595757 ]
        Rick Curtis made changes -
        Fix Version/s 1.2.4 [ 12324333 ]
        Fix Version/s 2.2.3 [ 12324305 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410r2.patch [ 12593205 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410r1.patch [ 12593200 ]
        Rick Curtis made changes -
        Description OpenJPA may contain illegal System.out/err.print(ln) statements. Those statements should be detected and an error should be thrown to the user so they are aware of them and remove them from the code. Certain System.out/err.print(ln) statements are allowed such as for tools and testing purpose. Those will be filtered out and will not cause an error.

        Files modified:
        checkstyle.xml
        pom.xml

        File added:
        suppressions.xml
        Source files may have inadvertent System.out/err.print statements left in source files on commit. Ideally we don't want any of these changes being checked in and a large majority of the time logging facilities should be utilized. That being said, there are a number of cases where we don't have access to a logger and must use System.out/err.

        This JIRA will be used to update our checkstyle to scan for unwanted print statements, and fail the build when/if they are encountered.
        Rick Curtis made changes -
        Summary Detection for Illegal System.out/err.print(ln) Statements in OpenJPA Build time detection of System.out/err.print(ln) in source files
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.patch [ 12592646 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.patch [ 12592605 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.patch [ 12592605 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.patch [ 12592594 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.patch [ 12592594 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.patch [ 12592560 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.patch [ 12592560 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.patch [ 12592376 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.final.patch [ 12592391 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.final.patch [ 12592391 ]
        Rick Curtis made changes -
        Fix Version/s 2.3.0 [ 12319463 ]
        Affects Version/s 2.3.0 [ 12319463 ]
        Rick Curtis made changes -
        Assignee Rick Curtis [ curtisr7 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.patch [ 12592376 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.patch [ 12592070 ]
        Albert Lee made changes -
        Patch Info Patch Available [ 10042 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Component/s build / infrastructure [ 12311640 ]
        Di Wu Lau made changes -
        Attachment OPENJPA-2410.patch [ 12592070 ]
        Di Wu Lau made changes -
        Attachment suppressions.xml [ 12592053 ]
        Di Wu Lau made changes -
        Attachment pom.xml [ 12592052 ]
        Di Wu Lau made changes -
        Attachment checkstyle.xml [ 12592054 ]
        Di Wu Lau made changes -
        Field Original Value New Value
        Attachment pom.xml [ 12592052 ]
        Attachment suppressions.xml [ 12592053 ]
        Attachment checkstyle.xml [ 12592054 ]
        Di Wu Lau created issue -

          People

          • Assignee:
            Rick Curtis
            Reporter:
            Di Wu Lau
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development