Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0
    • Component/s: None
    • Labels:
      None
    1. openjpa-asm4-shade.diff
      1 kB
      Romain Manni-Bucau

      Issue Links

        Activity

        Hide
        Romain Manni-Bucau added a comment -

        Hi Kevin

        TomEE is already using openjpa snapshot with this asm4 shade with success (replacing asm3 shade)

        Fyi cxf has the exact same strategy

        Show
        Romain Manni-Bucau added a comment - Hi Kevin TomEE is already using openjpa snapshot with this asm4 shade with success (replacing asm3 shade) Fyi cxf has the exact same strategy
        Hide
        Kevin Sutter added a comment -

        Mark,
        I'm confused by this latest commit. As far as I can tell, OpenJPA only has a dependency on ASM 3.2 (kernel's pom.xml). Although I agree that the changes you are introducing probably will help ASM 4 usage when we get there, I don't understand why this change was necessary when we haven't moved to ASM 4 yet... And, I'm not clear on this usage of the org.apache.xbean.asm and org.apache.xbean.asm4 package. So, we're modifying OpenJPA code everytime some user of OpenJPA has a shaded version of ASM? That doesn't sound very scalable... What am I missing?

        Show
        Kevin Sutter added a comment - Mark, I'm confused by this latest commit. As far as I can tell, OpenJPA only has a dependency on ASM 3.2 (kernel's pom.xml). Although I agree that the changes you are introducing probably will help ASM 4 usage when we get there, I don't understand why this change was necessary when we haven't moved to ASM 4 yet... And, I'm not clear on this usage of the org.apache.xbean.asm and org.apache.xbean.asm4 package. So, we're modifying OpenJPA code everytime some user of OpenJPA has a shaded version of ASM? That doesn't sound very scalable... What am I missing?
        Hide
        Mark Struberg added a comment -

        txs 4 the patch, applied

        Show
        Mark Struberg added a comment - txs 4 the patch, applied
        Hide
        ASF subversion and git services added a comment -

        Commit 1488102 from struberg
        [ https://svn.apache.org/r1488102 ]

        OPENJPA-2388 support for xbean shaded ASM4

        txs to rmannibucau for the patch!

        Show
        ASF subversion and git services added a comment - Commit 1488102 from struberg [ https://svn.apache.org/r1488102 ] OPENJPA-2388 support for xbean shaded ASM4 txs to rmannibucau for the patch!

          People

          • Assignee:
            Mark Struberg
            Reporter:
            Romain Manni-Bucau
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development