Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.2.3, 2.4.0
    • Component/s: Enhance
    • Labels:
      None

      Description

      There is a new version 1.14.2 of Serp that appears to fix OPENJPA-888 (https://issues.apache.org/jira/browse/OPENJPA-888).

      Would it be possible to update to 1.14.2 in OpenJPA?

      Serp 1.14.2 : http://serp.cvs.sourceforge.net/viewvc/serp/serp/
      Also: http://openjpa.apache.org/publishing-serp-to-maven-central-repository.html

        Issue Links

          Activity

          Hide
          kwsutter Kevin Sutter added a comment -

          Version 1.14.2 of Serp is actually "trunk". Trunk is the current snapshot for 1.14.2. So, pulling in a new version of "Serp 1.14.2" is not as easy as it sounds, unfortunately. This would require someone creating a new Serp release (not sure of the process) and then pulling it into the OpenJPA trunk. Pulling in a new/updated dependency into an OpenJPA service stream can be dangerous. In this case, maybe it could be considered a simple bug fix (moving from 1.14.1 to 1.14.2). I just looked at the source and here's the simple change that is in 1.14.2 that corrects the issue:

          public Instruction getEnd() {
          if (_end != null)
          return _end;
          int idx = _target.getByteIndex() + _length;
          Instruction end = getCode().getInstruction(idx);
          if (end != null && (end.prev instanceof Instruction))

          { // updated return (Instruction) end.prev; // new }

          return getCode().getLastInstruction();
          }

          Show
          kwsutter Kevin Sutter added a comment - Version 1.14.2 of Serp is actually "trunk". Trunk is the current snapshot for 1.14.2. So, pulling in a new version of "Serp 1.14.2" is not as easy as it sounds, unfortunately. This would require someone creating a new Serp release (not sure of the process) and then pulling it into the OpenJPA trunk. Pulling in a new/updated dependency into an OpenJPA service stream can be dangerous. In this case, maybe it could be considered a simple bug fix (moving from 1.14.1 to 1.14.2). I just looked at the source and here's the simple change that is in 1.14.2 that corrects the issue: public Instruction getEnd() { if (_end != null) return _end; int idx = _target.getByteIndex() + _length; Instruction end = getCode().getInstruction(idx); if (end != null && (end.prev instanceof Instruction)) { // updated return (Instruction) end.prev; // new } return getCode().getLastInstruction(); }
          Hide
          fyrewyld Jody Grassel added a comment -

          My upcoming changes to Serp to support Java 8 Lambdas will be going into the next Serp release, so we'll need to get the release process figured out in short order. Will use this JIRA to deliver my SERP changes.

          Show
          fyrewyld Jody Grassel added a comment - My upcoming changes to Serp to support Java 8 Lambdas will be going into the next Serp release, so we'll need to get the release process figured out in short order. Will use this JIRA to deliver my SERP changes.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1632148 from Jody Grassel in branch 'openjpa/trunk'
          [ https://svn.apache.org/r1632148 ]

          OPENJPA-2381: Upgrade Serp to 1.15.0

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1632148 from Jody Grassel in branch 'openjpa/trunk' [ https://svn.apache.org/r1632148 ] OPENJPA-2381 : Upgrade Serp to 1.15.0
          Hide
          fyrewyld Jody Grassel added a comment -

          Published Serp 1.15.0, updated trunk to consume it.

          Show
          fyrewyld Jody Grassel added a comment - Published Serp 1.15.0, updated trunk to consume it.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1641426 from Jody Grassel in branch 'openjpa/branches/2.2.x'
          [ https://svn.apache.org/r1641426 ]

          OPENJPA-2381: Update SERP to 1.15.1 [JDK 8]

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1641426 from Jody Grassel in branch 'openjpa/branches/2.2.x' [ https://svn.apache.org/r1641426 ] OPENJPA-2381 : Update SERP to 1.15.1 [JDK 8]
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1641442 from Jody Grassel in branch 'openjpa/trunk'
          [ https://svn.apache.org/r1641442 ]

          OPENJPA-2381: Update serp to 1.15.1

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1641442 from Jody Grassel in branch 'openjpa/trunk' [ https://svn.apache.org/r1641442 ] OPENJPA-2381 : Update serp to 1.15.1
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1641452 from Jody Grassel in branch 'openjpa/branches/2.3.x'
          [ https://svn.apache.org/r1641452 ]

          OPENJPA-2381: Update serp to 1.15.1

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1641452 from Jody Grassel in branch 'openjpa/branches/2.3.x' [ https://svn.apache.org/r1641452 ] OPENJPA-2381 : Update serp to 1.15.1

            People

            • Assignee:
              fyrewyld Jody Grassel
              Reporter:
              ddamours Danny D'Amours
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development