Uploaded image for project: 'OpenJPA'
  1. OpenJPA
  2. OPENJPA-2206

Bad practice - Method with Boolean return type returns explicit null

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.2.0
    • Fix Version/s: None
    • Component/s: Enhance
    • Labels:
      None

      Description

      FindBugs is reporting this error on our enhanced classes. The pcIsDetached() method appears to be the culprit. Details about the error:

      A method that returns either Boolean.TRUE, Boolean.FALSE or null is an accident waiting to happen. This method can be invoked as though it returned a value of type boolean, and the compiler will insert automatic unboxing of the Boolean value. If a null value is returned, this will result in a NullPointerException.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jwcarman James Carman
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: