OpenJPA
  1. OpenJPA
  2. OPENJPA-2034

Update H2 Database sql error codes as per the changes in v1.3.154

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.0
    • Fix Version/s: 2.2.0
    • Component/s: jdbc, sql
    • Labels:
      None
    • Environment:
      H2 v1.3.154 or higher
    • Patch Info:
      Patch Available

      Description

      SQL error state codes have been changed in H2 1.3.154 [1] With this change, many openjpa-jdbc-tests were failing. I've update the sql-error-state-codes.xml to use the correct codes, so it'll be great if the patch is reviewed and applied, Thanks.

      Regards,
      Prashant

      [1] http://www.h2database.com/html/changelog.html

      1. OPENJPA-2034.patch
        2 kB
        Prashant Bhat
      2. OPENJPA-2034.patch
        2 kB
        Prashant Bhat

        Activity

        Hide
        Albert Lee added a comment -

        Close issue in preparation for 2.2.0 release.

        Show
        Albert Lee added a comment - Close issue in preparation for 2.2.0 release.
        Hide
        Michael Dick added a comment -

        Thanks for the patch. The changes will show up in the next nightly snapshot for 2.2.0.

        Show
        Michael Dick added a comment - Thanks for the patch. The changes will show up in the next nightly snapshot for 2.2.0.
        Hide
        Prashant Bhat added a comment -

        Yes, they were mostly working, except for locking tests. And it's good to keep the previous codes also, so the older H2 releases will still be supported. I've updated the patch accordingly. Thanks for the review.

        Show
        Prashant Bhat added a comment - Yes, they were mostly working, except for locking tests. And it's good to keep the previous codes also, so the older H2 releases will still be supported. I've updated the patch accordingly. Thanks for the review.
        Hide
        Michael Dick added a comment -

        Prashant, in the patch you removed some of the old state codes (e.g 23001 for object-exists). Were these values correct for older versions of H2?

        What I'm getting at here is whether we can support the older versions of H2 with these changes.

        Show
        Michael Dick added a comment - Prashant, in the patch you removed some of the old state codes (e.g 23001 for object-exists). Were these values correct for older versions of H2? What I'm getting at here is whether we can support the older versions of H2 with these changes.
        Hide
        Prashant Bhat added a comment -

        Patch attached

        Show
        Prashant Bhat added a comment - Patch attached

          People

          • Assignee:
            Michael Dick
            Reporter:
            Prashant Bhat
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development