With this JIRA I'm going to change a number of methods / fields to protected to allow for greater extensibility.
Make some members of StateManagerImpl protected to allow for greater extensability
Making carte blanche changes sensitive/critical constructs to private fields as protected is a poor design practice.
We have met similar situation before. And the good practice is to
a) provide the nature and reason of extension one is looking for. This way some alternatives can be suggested that does not require such changes.
b) It is understood that some work may require some degree of access relaxation. But it is more prudent to make those relaxation as and when they are required
The committer is requested to response to the concerns as expressed above.
> Making carte blanche changes sensitive/critical constructs to private fields as protected is a poor design practice.
Or perhaps the original designer of this code didn't think that someone would want to extend this object.?
I'm currently reviewing the code as I am pretty certain that I didn't need to open up most of the members that I did.
The short answer of where I'm heading is that I need access to the _fieldImpl Object. Either that method needs to be marked protected, or a getter would need to be added. This array is used in some instances to store foreign keys of lazy fields.
Hopefully this isn't too cryptic of an answer...?
Closing resolved issues.